Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "chore(deps): upgrade pprof to v3.2.1 [security]" #884

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

aabmass
Copy link
Collaborator

@aabmass aabmass commented Jul 24, 2023

Reverts #883

  1. The actual commit ended up with the wrong version number
  2. release-please won't release this, it needs deps: ... format.

I will recreate the PR with correct commit message and try again.

@aabmass aabmass requested review from a team as code owners July 24, 2023 18:04
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. labels Jul 24, 2023
@aabmass aabmass requested a review from psx95 July 24, 2023 18:05
@codecov
Copy link

codecov bot commented Jul 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b1c0660) 68.87% compared to head (9142fc7) 68.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #884   +/-   ##
=======================================
  Coverage   68.87%   68.87%           
=======================================
  Files           7        7           
  Lines        1253     1253           
  Branches       58       58           
=======================================
  Hits          863      863           
  Misses        389      389           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@aabmass aabmass merged commit 56e5eb7 into main Jul 24, 2023
@aabmass aabmass deleted the revert-883-upgrade-pprof branch July 24, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: cloudprofiler Issues related to the googleapis/cloud-profiler-nodejs API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants