feat!: support user-specified context header propagation #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
kjin
force-pushed
the
propagation
branch
2 times, most recently
from
de17efe
to
f700581
Compare
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
+ Coverage 94.89% 94.98% +0.09%
==========================================
Files 96 96
Lines 6226 6246 +20
Branches 484 474 -10
==========================================
+ Hits 5908 5933 +25
+ Misses 161 159 -2
+ Partials 157 154 -3
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #1029 +/- ##
==========================================
+ Coverage 94.89% 94.95% +0.06%
==========================================
Files 96 96
Lines 6226 6249 +23
Branches 484 475 -9
==========================================
+ Hits 5908 5934 +26
+ Misses 161 160 -1
+ Partials 157 155 -2
Continue to review full report at Codecov.
|
BREAKING CHANGE: This change modifies/removes APIs that assume a particular format for trace context headers; in other words, any place where the user would deal with a stringified trace context, they would now deal with a TraceContext object instead. This affects three APIs: `getResponseTraceContext` (input/output has changed from string to TraceContext), `createRootSpan` (input RootSpanOptions now accepts a TraceContext instead of a string in the traceContext field), and `Span#getTraceContext` (output has changed from string to TraceContext).
DominicKramer
approved these changes
May 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #949, supercedes #950
With this change:
Tracer.@opencensus/propagation-stackdriver(behavior should match what the plugins do currently)Tracer#traceContextUtilsno longer has methods for encoding and decoding trace context as a string.TraceContextobjects instead of strings:Tracer#getResponseTraceContextTracer#createRootSpanSpan#getTraceContextpropagationfield with an instance ofOpenCensusPropagationto override the default implementation.