Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(storage): add key resource to HMAC methods that require it #54

Merged
merged 5 commits into from
Sep 2, 2021
Merged

fix(storage): add key resource to HMAC methods that require it #54

merged 5 commits into from
Sep 2, 2021

Conversation

BrennaEpp
Copy link
Contributor

No description provided.

@BrennaEpp
fix: fix typo in method names
e6757e5 
corrected to line up with the testbench as well as the api
@BrennaEpp
Add key resource to HMAC methods that require it
43d2b6c
@BrennaEpp BrennaEpp requested a review from BenWhitehead August 27, 2021 23:24
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Aug 27, 2021
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Aug 27, 2021
@BrennaEpp BrennaEpp requested a review from cojenco August 27, 2021 23:24
cojenco
cojenco approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@cojenco cojenco merged commit 64c08de into master Sep 2, 2021
@cojenco cojenco deleted the BrennaEpp-patch-2 branch September 2, 2021 19:50
@BenWhitehead BenWhitehead mentioned this pull request Sep 7, 2021
Merged
BenWhitehead added a commit to googleapis/java-conformance-tests that referenced this pull request Sep 8, 2021
@BenWhitehead
deps: bump conformance-tests to 5c25424bf26916f10275433b72b5b7e8c6e78…
932fd21 
…4ce (#363)

googleapis/conformance-tests@5c25424 chore: rename cloud-storage-dpes to cloud-storage-dpe ([#59](googleapis/conformance-tests#59))
googleapis/conformance-tests@32a2fd4 fix: update scenario 5 to only provide a single instruction for the expected failure ([#58](googleapis/conformance-tests#58))
googleapis/conformance-tests@0fe5931 fix(storage): add methods to s4 non idempotent operations ([#56](googleapis/conformance-tests#56))
googleapis/conformance-tests@64c08de fix(storage): add key resource to HMAC methods that require it ([#54](googleapis/conformance-tests#54))
googleapis/conformance-tests@17650a1 fix(storage): fix typo in method names ([#53](googleapis/conformance-tests#53))

Full diff: googleapis/conformance-tests@37ddc58...5c25424
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cojenco cojenco cojenco approved these changes

@BenWhitehead BenWhitehead Awaiting requested review from BenWhitehead

Assignees
No one assigned
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrennaEpp @cojenco