Skip to content
This repository has been archived by the owner on Sep 26, 2023. It is now read-only.

deps: update grpc to 1.42.1 #1559

Merged
merged 8 commits into from
Nov 29, 2021
Merged

deps: update grpc to 1.42.1 #1559

merged 8 commits into from
Nov 29, 2021

Conversation

Neenu1995
Copy link
Contributor

@Neenu1995 Neenu1995 commented Nov 16, 2021 •
edited
Loading

deps: update protobuf version to 3.19.1

@Neenu1995 Neenu1995 requested review from a team as code owners November 16, 2021 18:48
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 16, 2021
@suztomo
Copy link
Member

suztomo commented Nov 16, 2021 •
edited
Loading

ci / bazel failed:

ERROR: /github/home/.cache/bazel/_bazel_root/9e4dde399fac32001b99efa92054490b/external/io_grpc_grpc_java/alts/BUILD.bazel:82:18: in _java_grpc_library rule @io_grpc_grpc_java//alts:handshaker_java_grpc: 
Traceback (most recent call last):
	File "/github/home/.cache/bazel/_bazel_root/9e4dde399fac32001b99efa92054490b/external/io_grpc_grpc_java/java_grpc_library.bzl", line 100, column 36, in _java_rpc_library_impl
		java_info = java_common.compile(
Error in compile: compile() missing 1 required named argument: host_javabase
ERROR: Analysis of target '//gax-grpc:gax_grpc_testlib' failed; build aborted: Analysis of target '@io_grpc_grpc_java//alts:handshaker_java_grpc' failed

Retrying.

Still failed: https://github.com/googleapis/gax-java/runs/4229186018?check_suite_focus=true

@Neenu1995
Copy link
Contributor Author

Neenu1995 commented Nov 16, 2021 •
edited
Loading

GRPC 1.42.0 drops support for bazel 1-3 in this PR. The github action runner on this repo runs bazel 3.7.2, consequently the bazel check fails.

@Neenu1995
Copy link
Contributor Author

This error happened when the check was run in the googleapis container
Bazel: 4.0.0

ERROR: /github/home/.cache/bazel/_bazel_root/9e4dde399fac32001b99efa92054490b/external/com_google_protobuf/java/util/BUILD:7:13: no such package '@maven//': The repository '@maven' could not be resolved and referenced by '@com_google_protobuf//java/util:util'
ERROR: /github/home/.cache/bazel/_bazel_root/9e4dde399fac32001b99efa92054490b/external/com_google_protobuf/java/util/BUILD:7:13: no such package '@maven//': The repository '@maven' could not be resolved and referenced by '@com_google_protobuf//java/util:util'
ERROR: /github/home/.cache/bazel/_bazel_root/9e4dde399fac32001b99efa92054490b/external/com_google_protobuf/java/util/BUILD:7:13: no such package '@maven//': The repository '@maven' could not be resolved and referenced by '@com_google_protobuf//java/util:util'
ERROR: /github/home/.cache/bazel/_bazel_root/9e4dde399fac32001b99efa92054490b/external/com_google_protobuf/java/util/BUILD:7:13: no such package '@maven//': The repository '@maven' could not be resolved and referenced by '@com_google_protobuf//java/util:util'
ERROR: /github/home/.cache/bazel/_bazel_root/9e4dde399fac32001b99efa92054490b/external/com_google_protobuf/java/util/BUILD:7:13: no such package '@maven//': The repository '@maven' could not be resolved and referenced by '@com_google_protobuf//java/util:util'
ERROR: Analysis of target '//gax-grpc:gax_grpc_testlib' failed; build aborted: Analysis failed

suztomo
suztomo reviewed Nov 19, 2021
View reviewed changes
dependencies.properties
@@ -23,9 +23,9 @@ version.gax_httpjson=0.92.1-SNAPSHOT
# Versions for dependencies which actual artifacts differ between Bazel and Gradle.
# Gradle build depends on prebuilt maven artifacts, while Bazel build depends on Bazel workspaces
# with the sources.
version.com_google_protobuf=3.18.1
version.com_google_protobuf=3.19.1
Copy link
Member

@suztomo suztomo Nov 19, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per #1566, this protobuf version upgrade causes the problem "The repository '@maven' could not be resolved and referenced by '@com_google_protobuf//java/util:util". gRPC is not the one causing it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to upgrade to the latest in protobuf too. The rest of the java client libraries will upgrade to protobuf 3.19.1 with shared deps 2.5.0.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1571 will fix the protobuf problem.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1571 has been merged.

suztomo
suztomo reviewed Nov 29, 2021
View reviewed changes
.github/workflows/ci.yaml
@@ -22,7 +22,9 @@ jobs:

bazel:
runs-on: ubuntu-latest
container: gcr.io/gapic-images/googleapis-bazel:20210105
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This had Bazel 3.

@Neenu1995 Neenu1995 added the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2021
@Neenu1995 Neenu1995 merged commit 92b7632 into main Nov 29, 2021
@Neenu1995 Neenu1995 deleted the update-grpc branch November 29, 2021 19:20
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 29, 2021
@Neenu1995
Copy link
Contributor Author

Neenu1995 commented Nov 30, 2021 via email

gcf-merge-on-green bot pushed a commit that referenced this pull request Dec 2, 2021
@release-please
chore: release 2.7.1 (#1558)
c2083cc 
🤖 I have created a release \*beep\* \*boop\*
---
### [2.7.1](https://www.github.com/googleapis/gax-java/compare/v2.7.0...v2.7.1) (2021-12-02)


### Bug Fixes

* fix gRPC code conversion ([#1555](https://www.github.com/googleapis/gax-java/issues/1555)) ([09b99d5](https://www.github.com/googleapis/gax-java/commit/09b99d591497b44c3c25b1a54abb0f1cb69d7376))
* pass error message when creating ApiException ([#1556](https://www.github.com/googleapis/gax-java/issues/1556)) ([918ae41](https://www.github.com/googleapis/gax-java/commit/918ae419f84ad5721638ca10eca992333e9f7c3d))
* revert generics syntax change in MockHttpService test utility ([#1574](https://www.github.com/googleapis/gax-java/issues/1574)) ([b629488](https://www.github.com/googleapis/gax-java/commit/b629488ffc7d68158158d9197695158f97229c7b))
* update exception mapping on HTTP error responses ([#1570](https://www.github.com/googleapis/gax-java/issues/1570)) ([8a170d1](https://www.github.com/googleapis/gax-java/commit/8a170d19b42e9b13d4c69dcfbe531d4d4ca69c90))


### Dependencies

* update grpc to 1.42.1 ([#1559](https://www.github.com/googleapis/gax-java/issues/1559)) ([92b7632](https://www.github.com/googleapis/gax-java/commit/92b76325d54604c98c798c489b3a963fdf21a75c))
* upgrade protobuf to 3.19.1 ([#1571](https://www.github.com/googleapis/gax-java/issues/1571)) ([7b354e7](https://www.github.com/googleapis/gax-java/commit/7b354e73b8ce49008bed51076afb255ca5dc68e4))
---


This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@suztomo suztomo suztomo approved these changes

Assignees
No one assigned
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Neenu1995 @suztomo