Fix parameters of java_common.compile.

[comius]

Parameter host_javabase is removed

This is preparation for flipping incompatible_java_common_parameters.
See bazelbuild/bazel#12373

[linux-foundation-easycla]

The committers are authorized under a signed CLA.

• ✅ Ivo List (23b1294)

[comius]

Failing because of extra old Bazel version, 1.0.1?

[ejona86]

@comius, yeah, we test on the oldest version we support (and we generally run newer versions on our machines when developing). What is the oldest version that supports this change? You can change the version used to test at:

grpc-java/buildscripts/kokoro/bazel.sh

Line 6 in a589f52

use_bazel.sh 1.0.1

[ejona86]

It looks like this isn't compatible even with Bazel 3.7.1. It looks like we'll have to wait for 4.0, and even then we probably want to wait a while after 4.0 is out because changing this will force the new version no users.

I think it is probably best to close this for now. Agreed?

[comius]

It looks like this isn't compatible even with Bazel 3.7.1. It looks like we'll have to wait for 4.0, and even then we probably want to wait a while after 4.0 is out because changing this will force the new version no users.

I think it is probably best to close this for now. Agreed?

True, it is only compatible with Bazel 4.0, which is going to be released hopefully this December :). Bazel 4.0 is a LTS release so it is taking a bit longer. It might not be such a bad idea to merge this after it is released or alternatively wait for next LTS.

I would not like to force you to have two versions because of Bazel. But I also will never be able to flip the flag if you insist on supporting all versions from 1.0.1.

If you agree I'd leave this open and ping you in a year when next LTS release will need the change. This way I don't need to search for it.

[ejona86]

Bumping the oldest supported version is fine. We test on the old version just so we don't accidentally break old versions. Bumping to 4.0 the day of the release is probably not great, but when the following LTS is coming out or a few months before seems quite fair.

Leaving this open sounds fine.

[comius]

Bazel 4.x.x has been released now for 1 year. And we plan to do a cut off for Bazel 5.0.0 next week.

I would like to remove support for host_javabase in Bazel 5 by default.

[ejona86]

Oh, our CI is going to fail. @comius, could you update

grpc-java/buildscripts/kokoro/bazel.sh

Line 6 in 0d25d8f

use_bazel.sh 1.0.1

to use Bazel 4.0.0 instead? (Yes, we could use a newer version of Bazel in 4.x, but it is useful to know if we are hitting any bugs that would require even newer builds of Bazel. And we're bumping this from 1.0 so being a bit conservative doesn't seem a bad idea.)

[ejona86]

Actually, I can do that for you. Let me real quick so the CI starts running and we can get this done quickly for you.