-
Notifications
You must be signed in to change notification settings - Fork 119
feat: add support for quotaProjectId header #826
Conversation
9c16cc1
to
307ea38
Compare
After this change a release will need to be cut and core updated in order to make the proper changes there. |
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
============================================
+ Coverage 78.69% 78.71% +0.02%
- Complexity 1145 1146 +1
============================================
Files 202 202
Lines 5092 5098 +6
Branches 404 405 +1
============================================
+ Hits 4007 4013 +6
Misses 912 912
Partials 173 173
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #826 +/- ##
============================================
+ Coverage 78.69% 78.71% +0.02%
- Complexity 1145 1146 +1
============================================
Files 202 202
Lines 5092 5098 +6
Branches 404 405 +1
============================================
+ Hits 4007 4013 +6
Misses 912 912
Partials 173 173
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The gapic-only clients don't use google-cloud-core so there must be another place in the gax that would use this.
I think you are right. Looks like there is one spot that it is possible it does not get set when making a JWT ServiceAccount in |
What's the meaning of the token suffix? A project ID doesn't match with the common understanding of "token" |
@broady nothing special. Looking at the others properties of the builder, it did not seem like Token applied to them either(at least not all). I could be wrong on this though as the class does not document what its properties are for. So I went with consistency of api related to other fields. If you think it is right though, we can drop the suffix. I will have to just deprecate the old one though for now as a release has already happened. |
@codyoss I looked more, it looks like "token" really only makes sense for constructing the client string. I think "resource token" and "quota project id token" don't make sense. Seems fine to leave as-is if users aren't typically interacting with this package. |
No description provided.