This repository has been archived by the owner on Dec 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
feat: support setting ServiceOption for quota project #92
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Dec 11, 2019
Before this can work two PRs need to be merged and their artifacts released:
Will update this PR after that happens |
codyoss
added
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Dec 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
============================================
+ Coverage 66.43% 66.64% +0.21%
- Complexity 367 370 +3
============================================
Files 34 34
Lines 1865 1877 +12
Branches 236 240 +4
============================================
+ Hits 1239 1251 +12
Misses 524 524
Partials 102 102
Continue to review full report at Codecov.
|
codyoss
removed
the
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
label
Dec 13, 2019
elharo
reviewed
Dec 13, 2019
chingor13
suggested changes
Dec 13, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small testing nit
google-cloud-core/src/test/java/com/google/cloud/ServiceOptionsTest.java
Show resolved
Hide resolved
chingor13
suggested changes
Dec 13, 2019
google-cloud-core/src/test/java/com/google/cloud/ServiceOptionsTest.java
Outdated
Show resolved
Hide resolved
chingor13
approved these changes
Dec 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.