Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for universe domain #4675

Merged
merged 2 commits into from
Apr 23, 2024
Merged

feat: add support for universe domain #4675

merged 2 commits into from
Apr 23, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Feb 20, 2024

adds new $rootUrlTemplate property to all service classes in order to support the universe domain option in googleapis/google-api-php-client#2563

@bshaffer bshaffer changed the title WIP feat: add support for universe domain Feb 20, 2024
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@bshaffer bshaffer marked this pull request as ready for review February 27, 2024 23:30
@bshaffer bshaffer requested review from yoshi-approver and a team as code owners February 27, 2024 23:30
@@ -331,8 +331,11 @@ def _NormalizeUrlComponents(self):
scheme = url_parts.scheme or 'https'
service_host = url_parts.netloc or _DEFAULT_SERVICE_HOST
base_path = url_parts.path
if not root_url:
if root_url:
self._api.SetTemplateValue('rootUrlTemplate', root_url.replace('googleapis.com', 'UNIVERSE_DOMAIN'))

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This might break though, if users have a rooturl like:
usergoogleapis.com, it would be changed to userUNIVERSE_DOMAIN.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure though how big of a usecase this is... a client using TPC and their domain name has googleapis.com

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could replace .googleapis.com with .UNIVERSE_DOMAIN if you think that would be safer.

src/DataprocMetastore.php Outdated Show resolved Hide resolved
@bshaffer bshaffer enabled auto-merge (squash) April 23, 2024 21:23
@bshaffer bshaffer merged commit 67c0f7c into main Apr 23, 2024
12 checks passed
@bshaffer bshaffer deleted the universe-domain branch April 23, 2024 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants