Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add universe domain support #2563

Merged
merged 14 commits into from
Apr 24, 2024
Merged

feat: add universe domain support #2563

merged 14 commits into from
Apr 24, 2024

Conversation

bshaffer
Copy link
Contributor

@bshaffer bshaffer commented Feb 20, 2024

  • add tests
  • E2E manual test
  • Support for GOOGLE_CLOUD_UNIVERSE_DOMAIN environment variable
  • Support universe domain in Batch

See also googleapis/google-api-php-client-services#4675

The following manual test worked using this branch:

$universeDomain = 'MY_UNIVERSE_DOMAIN';
$projectId = 'MY_PROJECT_ID';

$client = new Google\Client([
    'universe_domain' => $universeDomain,
    'scopes' => ['https://www.googleapis.com/auth/cloud-platform'],
]);
$client->useApplicationDefaultCredentials();
$storage = new Google\Service\Storage($client);

$buckets = $storage->buckets->listBuckets($projectId);

foreach ($buckets as $bucket) {
    echo $bucket->name . PHP_EOL;
}

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Client.php Outdated Show resolved Hide resolved
@bshaffer bshaffer marked this pull request as ready for review February 27, 2024 23:24
@bshaffer bshaffer requested a review from a team as a code owner February 27, 2024 23:24
Co-authored-by: Vishwaraj Anand <vishwaraj.anand00@gmail.com>
@bshaffer bshaffer merged commit 35895de into main Apr 24, 2024
12 checks passed
@bshaffer bshaffer deleted the universe-domain branch April 24, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants