-
Notifications
You must be signed in to change notification settings - Fork 227
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support reading in quotaProjectId for billing #383
Conversation
c9c1f7b
to
1a760d6
Compare
1a760d6
to
40ce4a1
Compare
Codecov Report
@@ Coverage Diff @@
## master #383 +/- ##
============================================
- Coverage 79.63% 79.53% -0.11%
- Complexity 389 397 +8
============================================
Files 27 27
Lines 1758 1803 +45
Branches 181 188 +7
============================================
+ Hits 1400 1434 +34
- Misses 262 269 +7
- Partials 96 100 +4
Continue to review full report at Codecov.
|
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/java/com/google/auth/oauth2/ServiceAccountCredentials.java
Outdated
Show resolved
Hide resolved
oauth2_http/javatests/com/google/auth/oauth2/ServiceAccountCredentialsTest.java
Show resolved
Hide resolved
* @return New ServiceAccountJwtAcceessCredentials created from a private key. | ||
* @throws IOException if the credential cannot be created from the private key. | ||
*/ | ||
public static ServiceAccountJwtAccessCredentials fromPkcs8( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one is also unnecessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this one actually needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say yes actually for this one. I moved it to package scope though as to not expose more surface to the api.
No description provided.