feat: defines `IdentityPoolClient` used for K8s and Azure workloads #1042

bojeil-google · 2020-08-19T01:07:06Z

This will subclass the abstract class BaseExternalAccountClient and will retrieve subject tokens from URLs (eg Azure Instance Metadata Service) or a file location (K8s KSA tokens).

Renamed ExternalAccountClient to BaseExternalAccountClient. The latter will not be exported. Instead the former will be created as an empty class with a static fromJSON() method to initialize the right type of external client (IdentityPoolClient or AwsClient).

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/5f7f9c6d-c75a-4c60-8bb8-0026a14cead7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@94421c4

This PR was generated using Autosynth. 🌈 Synth log will be available here: https://source.cloud.google.com/results/invocations/b742586e-df31-4aac-8092-78288e9ea8e7/targets - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@bd0deaa

This PR was generated using Autosynth. 🌈 - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5747555

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

This will subclass the abstract class `BaseExternalAccountClient` and will retrieve subject tokens from URLs (eg Azure Instance Metadata Service) or a file location (K8s KSA tokens). Renamed `ExternalAccountClient` to `BaseExternalAccountClient`. The latter will not be exported. Instead the former will be created as an empty class with a static `fromJSON()` method to initialize the right type of external client.

codecov · 2020-08-19T01:07:11Z

Codecov Report

❗ No coverage uploaded for pull request base (byoid@424755c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             byoid    #1042   +/-   ##
========================================
  Coverage         ?   93.10%           
========================================
  Files            ?       25           
  Lines            ?     5092           
  Branches         ?      543           
========================================
  Hits             ?     4741           
  Misses           ?      351           
  Partials         ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 424755c...e909a16. Read the comment docs.

google-cla · 2020-08-19T01:07:16Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-08-19T01:42:04Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

google-cla · 2020-08-21T02:16:05Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

bcoe

Left a few nits, but this is looking pretty solid to me.

bcoe · 2020-08-21T02:22:40Z

test/test.identitypoolclient.ts

+  const projectNumber = '123456';
+  const poolId = 'POOL_ID';
+  const providerId = 'PROVIDER_ID';
+  const audience =


If all these variables are used by the audience URL, and not elsewhere in test, I would be tempted to encapsulate them in a test helper, like getAudienceUrl; I read this and my immediate reaction was, that's a lot of variables, before I realized they're not all used in test cases.

Ok, I made some refactor and moved a lot of these constants to common file and exported helper functions which are used by 2 test files.

bcoe · 2020-08-21T02:24:42Z

src/auth/identitypoolclient.ts

+      throw err;
+    }
+
+    const stream = fs.createReadStream(filePath);


an alternate approach to createReadStream, I believe would be using the promises API:

const {readFile} = require('fs').promises async function main () { return readFile(filePath) }

I ended up using utils.promisify(fs.readFile) since Node 10 does not seem to play well with fs.promises.

…misify(fs.readFile)`.

google-cla · 2020-08-21T03:15:26Z

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

feat: implements the OAuth token exchange spec based on rfc8693 (#1026) feat: defines ExternalAccountClient abstract class for external_account credentials (#1030) feat: adds service account impersonation to `ExternalAccountClient` (#1041) feat: defines `IdentityPoolClient` used for K8s and Azure workloads (#1042) feat: implements AWS signature version 4 for signing requests (#1047) feat: defines `ExternalAccountClient` used to instantiate external account clients (#1050) feat!: integrates external_accounts with `GoogleAuth` and ADC (#1052) feat: adds text/json credential_source support to IdentityPoolClients (#1059) feat: get AWS region from environment variable (#1067) Co-authored-by: Wilfred van der Deijl <wilfred@vanderdeijl.com> Co-authored-by: Benjamin E. Coe <bencoe@google.com>

grayside and others added 11 commits August 7, 2020 16:32

refactor(samples): idtoken-cloudrun => idtoken-serverless (#1025)

11b0cb7

docs: README updated with new sample paths

4df48df

chore: release 6.0.7 (#1023)

6dfee1d

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

fix(deps): roll back dependency google-auth-library to ^6.0.6 (#1033)

eb54ee9

build: perform publish using Node 12 (#1035)

714247d

This PR was generated using Autosynth. 🌈 - [ ] To automatically regenerate this PR, check this box. Source-Link: googleapis/synthtool@5747555

chore: release 6.0.8 (#1036)

211e042

* chore: updated samples/package.json [ci skip] * chore: updated CHANGELOG.md [ci skip] * chore: updated package.json Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>

Merge remote-tracking branch 'upstream/byoid'

577b78b

Merge remote-tracking branch 'upstream/byoid'

60e6c42

bojeil-google requested a review from a team as a code owner August 19, 2020 01:07

blunderbuss-gcf bot assigned sofisl Aug 19, 2020

google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 19, 2020

Fixes file path matching in error messages for windows.

010fa32

Fixes typo in the sample STS audience name used in the tests.

32b0619

bcoe added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 21, 2020

bcoe suggested changes Aug 21, 2020

View reviewed changes

Created common file for test helpers and switched to using `utils.pro…

e909a16

…misify(fs.readFile)`.

google-cla bot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Aug 21, 2020

bcoe approved these changes Aug 21, 2020

View reviewed changes

bcoe merged commit bbcd03d into googleapis:byoid Aug 21, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: defines `IdentityPoolClient` used for K8s and Azure workloads #1042

feat: defines `IdentityPoolClient` used for K8s and Azure workloads #1042

bojeil-google commented Aug 19, 2020

codecov bot commented Aug 19, 2020 •

edited

Loading

google-cla bot commented Aug 19, 2020

google-cla bot commented Aug 19, 2020

google-cla bot commented Aug 21, 2020

bcoe left a comment

bcoe Aug 21, 2020

bojeil-google Aug 21, 2020

bcoe Aug 21, 2020

bojeil-google Aug 21, 2020

google-cla bot commented Aug 21, 2020

feat: defines IdentityPoolClient used for K8s and Azure workloads #1042

feat: defines IdentityPoolClient used for K8s and Azure workloads #1042

Conversation

bojeil-google commented Aug 19, 2020

codecov bot commented Aug 19, 2020 • edited Loading

Codecov Report

google-cla bot commented Aug 19, 2020

google-cla bot commented Aug 19, 2020

google-cla bot commented Aug 21, 2020

bcoe left a comment

Choose a reason for hiding this comment

bcoe Aug 21, 2020

Choose a reason for hiding this comment

bojeil-google Aug 21, 2020

Choose a reason for hiding this comment

bcoe Aug 21, 2020

Choose a reason for hiding this comment

bojeil-google Aug 21, 2020

Choose a reason for hiding this comment

google-cla bot commented Aug 21, 2020

feat: defines `IdentityPoolClient` used for K8s and Azure workloads #1042

feat: defines `IdentityPoolClient` used for K8s and Azure workloads #1042

codecov bot commented Aug 19, 2020 •

edited

Loading