-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can't build with MinGW: BCRYPT_SHA256_ALG_HANDLE isn't defined #14436
Comments
Thanks for the detailed bug report and the proposed patch. I cannot think of a better solution at this time. |
### Rationale for this change `google_cloud_cpp_mocks` depends on `GTest::gmock_main` but it's built without `BUILD_TESTING`. google-cloud-cpp finds GoogleTest only with `BUILD_TESTING`. ### What changes are included in this PR? The recent google-cloud-cpp doesn't build `google_cloud_cpp_mocks` without `BUILD_TESTING`. Note that we can't use 2.23.0 or later because they can't be built with MinGW-w64. See also: * mingw-w64/mingw-w64#49 * googleapis/google-cloud-cpp#14436 ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #43134 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
### Rationale for this change `google_cloud_cpp_mocks` depends on `GTest::gmock_main` but it's built without `BUILD_TESTING`. google-cloud-cpp finds GoogleTest only with `BUILD_TESTING`. ### What changes are included in this PR? The recent google-cloud-cpp doesn't build `google_cloud_cpp_mocks` without `BUILD_TESTING`. Note that we can't use 2.23.0 or later because they can't be built with MinGW-w64. See also: * mingw-w64/mingw-w64#49 * googleapis/google-cloud-cpp#14436 ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: #43134 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
As you may have noticed, I sent a PR based on your patch. I expect this PR will get a review on Monday. I expect that will get merged and then be part of the next release (v2.27.0) due early in 2024-08. |
Thanks! FYI: The next version of MinGW-w64's bcrypt.h will have |
…che#43136) ### Rationale for this change `google_cloud_cpp_mocks` depends on `GTest::gmock_main` but it's built without `BUILD_TESTING`. google-cloud-cpp finds GoogleTest only with `BUILD_TESTING`. ### What changes are included in this PR? The recent google-cloud-cpp doesn't build `google_cloud_cpp_mocks` without `BUILD_TESTING`. Note that we can't use 2.23.0 or later because they can't be built with MinGW-w64. See also: * mingw-w64/mingw-w64#49 * googleapis/google-cloud-cpp#14436 ### Are these changes tested? Yes. ### Are there any user-facing changes? Yes. * GitHub Issue: apache#43134 Authored-by: Sutou Kouhei <kou@clear-code.com> Signed-off-by: Sutou Kouhei <kou@clear-code.com>
Does this issue affect the google-cloud-cpp project? If the problem is with
the Google Cloud service exposed by the
google-cloud-cpp
libraries instead ofthe client libraries themselves, you may consider opening a support request
instead. The
google-cloud-cpp
developers cannot help you troubleshoot problemswith the service itself.
Yes.
What component of
google-cloud-cpp
is this related to? For example, isthis related to bigtable (i.e., something in
google/cloud/bigtable
), or GCS(i.e., something in
google/cloud/storage
)?google/cloud/internal/sha256_hash.cc
google/cloud/internal/sha256_hmac.cc
Describe the bug A clear and concise description of what the bug is.
I don't think that this is a bug of google-cloud-cpp but the latest release can't be built with MinGW-w64 because MinGW-w64's
bcrypt.h
doesn't provideBCRYPT_SHA256_ALG_HANDLE
.See also: mingw-w64/mingw-w64#49
So we can't build the latest google-cloud-cpp with MinGW-w64. Here are build error logs in apache/arrow:
With GCC: https://github.com/apache/arrow/actions/runs/9784972906/job/27017012557#step:7:1038
With clang: https://github.com/apache/arrow/actions/runs/9784972906/job/27017012746#step:7:977
To Reproduce Steps to reproduce the behavior:
Expected behavior A clear and concise description of what you expected to
happen.
google-cloud-cpp can be built with MinGW-w64.
Operating system: If you are using a Linux distribution please include the
name and version of the distribution too.
Windows.
What compiler and version are you using? Please include the output of
g++ -v
orclang++ -v
or the equivalent command-line flag.https://github.com/apache/arrow/actions/runs/9784972906/job/27017012557#step:7:96
https://github.com/apache/arrow/actions/runs/9784972906/job/27017012746#step:7:96
What version of
google-cloud-cpp
are you using? Please include the outputfrom
git rev-parse HEAD
if you are compiling from source, or the versionnumber from the applicable
google/cloud/*/version.h
file.https://github.com/googleapis/google-cloud-cpp/releases/tag/v2.26.0
Additional context Add any other context about the problem here.
I haven't tried yet but the following patch may work:
The text was updated successfully, but these errors were encountered: