Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround missing SHA256 macros in MinGW-w64 #14437

Merged

Conversation

coryan
Copy link
Member

@coryan coryan commented Jul 4, 2024

@coryan coryan added the gha:full-build Trigger a full build in GHA label Jul 4, 2024
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (f54ba19) to head (c801913).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14437      +/-   ##
==========================================
- Coverage   93.59%   93.58%   -0.01%     
==========================================
  Files        2313     2313              
  Lines      206983   206983              
==========================================
- Hits       193723   193715       -8     
- Misses      13260    13268       +8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 4, 2024 16:21
@coryan coryan requested a review from a team as a code owner July 4, 2024 16:21
@coryan coryan merged commit d565cb6 into googleapis:main Jul 6, 2024
90 checks passed
@coryan coryan deleted the fix-workaround-missing-sha256-macros-in-mingw branch July 6, 2024 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gha:full-build Trigger a full build in GHA
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't build with MinGW: BCRYPT_SHA256_ALG_HANDLE isn't defined
2 participants