-
Notifications
You must be signed in to change notification settings - Fork 374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage): support object retention #14351
feat(storage): support object retention #14351
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14351 +/- ##
========================================
Coverage 93.19% 93.19%
========================================
Files 2187 2191 +4
Lines 192250 192367 +117
========================================
+ Hits 179160 179272 +112
- Misses 13090 13095 +5 ☔ View full report in Codecov by Sentry. |
Implement support for object retention. This introduces a new object metadata field. Any patch or update operation that changes this field requires an extra option (`OverrideUnlockedRetention`).
c048457
to
8c4416c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except for two tiny comments.
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated by snippet-bot.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Implement support for object retention. This introduces a new object
metadata field. Any patch or update operation that changes this field
requires an extra option (
OverrideUnlockedRetention
).Part of the work for #12994
This change is