Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(storage): support object retention #14351

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Jun 18, 2024

Implement support for object retention. This introduces a new object
metadata field. Any patch or update operation that changes this field
requires an extra option (OverrideUnlockedRetention).

Part of the work for #12994


This change is Reviewable

@coryan coryan changed the title Feat-storage-object-retention-pr2 feat(storage): support object retention Jun 18, 2024
Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 98.31933% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.19%. Comparing base (b514243) to head (b2c1d55).

Current head b2c1d55 differs from pull request most recent head 08c1e9a

Please upload reports for the commit 08c1e9a to get more accurate results.

Files Patch % Lines
google/cloud/storage/override_unlocked_retention.h 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #14351    +/-   ##
========================================
  Coverage   93.19%   93.19%            
========================================
  Files        2187     2191     +4     
  Lines      192250   192367   +117     
========================================
+ Hits       179160   179272   +112     
- Misses      13090    13095     +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Implement support for object retention. This introduces a new object
metadata field. Any patch or update operation that changes this field
requires an extra option (`OverrideUnlockedRetention`).
@coryan coryan marked this pull request as ready for review June 18, 2024 20:42
@coryan coryan requested review from a team as code owners June 18, 2024 20:42
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for two tiny comments.

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jun 19, 2024
Copy link

snippet-bot bot commented Jun 19, 2024

Here is the summary of changes.

You are about to add 2 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

Copy link
Contributor Author

@coryan coryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@coryan coryan enabled auto-merge (squash) June 19, 2024 13:19
@coryan coryan merged commit 8abbf37 into googleapis:main Jun 19, 2024
66 checks passed
@coryan coryan deleted the feat-storage-object-retention-pr2 branch June 19, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants