Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(otel): bazel flag is obsolete #14416

Merged
merged 3 commits into from
Jul 3, 2024

Conversation

dbolduc
Copy link
Member

@dbolduc dbolduc commented Jul 1, 2024

In v1.16.0, OpenTelemetry started compiling with Abseil all the time with Bazel. See open-telemetry/opentelemetry-cpp#2679

This means their --io_opentelemetry_cpp//api:with_abseil flag is now obsolete. Yay. That is good moving forward.

They plan to remove the flag in the future.

The annoying this is that we cannot know which version of OpenTelemetry a downstream target is using. So we will not know if the flag is required or if the flag has been removed. Yuck.

I think our best path forward is to adapt to the change, and try to alert customers to configuration errors through documentation.


This change is Reviewable

Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.58%. Comparing base (bdecef6) to head (9c75b62).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14416   +/-   ##
=======================================
  Coverage   93.58%   93.58%           
=======================================
  Files        2313     2313           
  Lines      206884   206884           
=======================================
+ Hits       193617   193619    +2     
+ Misses      13267    13265    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@coryan coryan marked this pull request as ready for review July 1, 2024 21:43
@coryan coryan requested a review from a team as a code owner July 1, 2024 21:43
build --@google_cloud_cpp//:enable_opentelemetry

# OpenTelemetry versions < v1.16.0 are not compatible with Abseil
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After me, nobody will read this comment block. doc/packaging.md may be a better place, or the CHANGELOG.md file.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nobody will read this comment block.

Likely true. I was really banking on people finding the write up in the quickstart's README.

doc/packaging.md may be a better place, or the CHANGELOG.md file.

You are probably right that the more places we say words the better. I wrote up some words in the CHANGELOG. I also added a link (if you click enough times) from the packaging doc to the quickstart README.

@dbolduc dbolduc merged commit c39fb3a into googleapis:main Jul 3, 2024
62 of 63 checks passed
@dbolduc dbolduc deleted the otel-bazel-drop-absl-flag branch July 3, 2024 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants