-
Notifications
You must be signed in to change notification settings - Fork 396
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bazel] Bump version and deps #2679
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2679 +/- ##
==========================================
+ Coverage 87.12% 87.68% +0.56%
==========================================
Files 200 190 -10
Lines 6109 5851 -258
==========================================
- Hits 5322 5130 -192
+ Misses 787 721 -66 |
abseil has a lot of these now, none of them seem actionable
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the fix.
To be honest, bazel just feel like a black whole to otel-cpp maintainers currently,
which makes it challenging to maintain, so this PR is all the more appreciated.
Please add comments about apple_support
and rules_apple
, it will go a very long way to help us.
Don't pay attention to CI breaks, this is a general github issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. with nit comment on documenting the abseil requirement.
addressed all the comments here! |
Thanks all! |
This updates bazel as well as the deps that were required to be updated in order to support the newer version of bazel.
Fixes #2619