Revert "chore(deps): update dependency grpc/grpc to v1.38.1" #6840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 02e449b.
google-cla
bot
added
the
cla: yes
|
This revert is because after this PR our |
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6840 +/- ##
==========================================
- Coverage 95.04% 95.03% -0.01%
==========================================
Files 1264 1264
Lines 113312 113312
==========================================
- Hits 107694 107685 -9
- Misses 5618 5627 +9
Continue to review full report at Codecov.
|
devbww
approved these changes
Jun 22, 2021
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
Jun 22, 2021
There's a [bug] w/ CentOS-7's version of `pkg-config` that can cause invocations to take a reeeeeaaaaly long time to complete. We discovered this when upgrading to grpc-1.38.1 and had to [rollback] the upgrade. The fix to `pkg-config` was rolled out about 8 years ago in `pkg-config` 0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest as of this writing. After this, I think we should be able to upgrade grpc again. [bug]: https://bugs.freedesktop.org/show_bug.cgi?id=54716 [rollback]: googleapis#6840
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
Jun 22, 2021
There's a [bug] w/ CentOS-7's version of `pkg-config` that can cause invocations to take a reeeeeaaaaly long time to complete. We discovered this when upgrading to grpc-1.38.1 and had to [rollback] the upgrade. The fix to `pkg-config` was rolled out about 8 years ago in `pkg-config` 0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest as of this writing. After this, I think we should be able to upgrade grpc again. [bug]: https://bugs.freedesktop.org/show_bug.cgi?id=54716 [rollback]: googleapis#6840
devjgm
added a commit
to devjgm/google-cloud-cpp
that referenced
this pull request
Jun 23, 2021
There's a [bug] w/ CentOS-7's version of `pkg-config` that can cause invocations to take a reeeeeaaaaly long time to complete. We discovered this when upgrading to grpc-1.38.1 and had to [rollback] the upgrade. The fix to `pkg-config` was rolled out about 8 years ago in `pkg-config` 0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest as of this writing. After this, I think we should be able to upgrade grpc again. [bug]: https://bugs.freedesktop.org/show_bug.cgi?id=54716 [rollback]: googleapis#6840
devjgm
added a commit
that referenced
this pull request
Jun 23, 2021
There's a [bug] w/ CentOS-7's version of `pkg-config` that can cause invocations to take a reeeeeaaaaly long time to complete. We discovered this when upgrading to grpc-1.38.1 and had to [rollback] the upgrade. The fix to `pkg-config` was rolled out about 8 years ago in `pkg-config` 0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest as of this writing. After this, I think we should be able to upgrade grpc again. [bug]: https://bugs.freedesktop.org/show_bug.cgi?id=54716 [rollback]: #6840
|
Following up: The underlying issue was that centos-7's |
|
Renovate tries to minimize the "noise", and only sends one PR (ever) for each version. I think renovate would not send a new PR unless:
I just renamed the old PRs, let's see what happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #6827
This change is