chore(deps): upgrade pkg-config on CentOS-7 to avoid bug #6846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
googlebot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
devjgm
force-pushed
the
centos7-pkg-config
branch
from
2ebf36a
to
2a3314e
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #6846 +/- ##
=======================================
Coverage 95.02% 95.02%
=======================================
Files 1264 1264
Lines 113324 113324
=======================================
+ Hits 107682 107686 +4
+ Misses 5642 5638 -4
Continue to review full report at Codecov.
|
coryan
approved these changes
Jun 22, 2021
There's a [bug] w/ CentOS-7's version of `pkg-config` that can cause invocations to take a reeeeeaaaaly long time to complete. We discovered this when upgrading to grpc-1.38.1 and had to [rollback] the upgrade. The fix to `pkg-config` was rolled out about 8 years ago in `pkg-config` 0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest as of this writing. After this, I think we should be able to upgrade grpc again. [bug]: https://bugs.freedesktop.org/show_bug.cgi?id=54716 [rollback]: googleapis#6840
devjgm
force-pushed
the
centos7-pkg-config
branch
from
2a3314e
to
a249c26
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There's a bug w/ CentOS-7's version of
pkg-configthat can causeinvocations to take a reeeeeaaaaly long time to complete. We discovered
this when upgrading to grpc-1.38.1 and had to rollback the upgrade.
The fix to
pkg-configwas rolled out about 8 years ago inpkg-config0.28. This PR upgrades the pkg-config we use on CentOS-7 to the latest
as of this writing. After this, I think we should be able to upgrade
grpc again.
This change is