feat(GCS+gRPC): synthetic object metadata links #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7563 +/- ##
==========================================
- Coverage 93.31% 93.31% -0.01%
==========================================
Files 1381 1381
Lines 119588 119606 +18
==========================================
+ Hits 111598 111613 +15
- Misses 7990 7993 +3
Continue to review full report at Codecov.
|
devbww
approved these changes
Nov 4, 2021
The JSON API provides links to the media and metadata contents of each object as part of the object metadata. The gRPC API does not provide such links. While not strictly necessary, I think it is nice to create synthetic versions of these links.
coryan
force-pushed
the
feat-GCS+gRPC-create-synthetic-object-metadata-links
branch
from
63bfff0
to
4718572
Compare
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
coryan
deleted the
feat-GCS+gRPC-create-synthetic-object-metadata-links
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The JSON API provides links to the media and metadata contents of each
object as part of the object metadata. The gRPC API does not provide
such links. While not strictly necessary, I think it is nice to create
synthetic versions of these links.
This change is