Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(storage): reduce iterations in integration test #7564

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 4, 2021

WIP

I made this change because another PR #7563 keeps failing, and (1) that PR should not affect this test, (2) the failure is specific to one build, and (3) I am like 😕 and want to rule one some weird thing in Kokoro or something.


This change is Reviewable

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Nov 4, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Nov 4, 2021
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 4c635f52f67c2cc5538b78de5105bf8529100ea8

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Nov 5, 2021

Codecov Report

Merging #7564 (f2dbf5b) into main (6f47d5b) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7564   +/-   ##
=======================================
  Coverage   93.31%   93.31%           
=======================================
  Files        1381     1381           
  Lines      119589   119588    -1     
=======================================
+ Hits       111595   111599    +4     
+ Misses       7994     7989    -5     
Impacted Files Coverage Δ
...gle/cloud/storage/tests/thread_integration_test.cc 93.44% <100.00%> (-0.06%) ⬇️
google/cloud/pubsub/samples/samples.cc 92.02% <0.00%> (-0.08%) ⬇️
...cloud/pubsub/internal/subscription_session_test.cc 98.00% <0.00%> (+0.24%) ⬆️
...le/cloud/storage/internal/curl_download_request.cc 89.62% <0.00%> (+0.37%) ⬆️
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
google/cloud/bigtable/internal/common_client.cc 97.14% <0.00%> (+1.42%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.51% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f47d5b...f2dbf5b. Read the comment docs.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 82c31981a6726b8e17f39a4fa8abe3d1d148f582

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: fceaaf1027bedbefabac027ab5e6375debad29a8

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan force-pushed the test-storage-reduce-iterations-in-threading-test branch from fceaaf1 to 3fae374 Compare November 5, 2021 12:08
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 3fae374a254ca3460c39f96377570afc3a534bbf

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan
Copy link
Contributor Author

coryan commented Nov 5, 2021

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: d946a78c1bc45182450c4ef57a3b253de24d4d80

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f2dbf5b0cf25e411369f808c52b8a87bda1cffc7

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@coryan coryan marked this pull request as ready for review November 5, 2021 16:39
@coryan coryan requested a review from a team as a code owner November 5, 2021 16:39
Copy link
Contributor

@devbww devbww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/WIP//

@coryan coryan merged commit 656932b into googleapis:main Nov 5, 2021
@coryan coryan deleted the test-storage-reduce-iterations-in-threading-test branch November 5, 2021 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the Cloud Storage API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants