-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup: use script to update external/googleapis #7650
cleanup: use script to update external/googleapis #7650
Conversation
Use a script to update the list of `.proto` files use by each library, as well as the list of libraries each library depends on. The more complicated case was the `google-cloud-cpp::logging_type_protos` library, its name does not match the Bazel rules where it would generate `*logging_type_type_protos`. I introduced an `INTERFACE` library for backwards compatibility. In the bigquery library we are exposing both the `v1beta1/` and `v1/` versions of `connection.proto`. I will figure out how to clean that up in a future PR.
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7650 +/- ##
==========================================
- Coverage 95.28% 95.28% -0.01%
==========================================
Files 1254 1254
Lines 113227 113227
==========================================
- Hits 107891 107885 -6
- Misses 5336 5342 +6
Continue to review full report at Codecov.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 25 of 26 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @coryan)
Use a script to update the list of
.proto
files use by each library,as well as the list of libraries each library depends on.
The more complicated case was the
google-cloud-cpp::logging_type_protos
library, its name does not match the Bazel rules where it would generate
*logging_type_type_protos
. I introduced anINTERFACE
library forbackwards compatibility.
In the bigquery library we are exposing both the
v1beta1/
andv1/
versions of
connection.proto
. I will figure out how to clean that upin a future PR.
This change is