Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: use script to update external/googleapis #7650

Merged
merged 4 commits into from
Nov 23, 2021
Merged

cleanup: use script to update external/googleapis #7650

merged 4 commits into from
Nov 23, 2021

Commits on Nov 22, 2021

  1. cleanup: use script to update external/googleapis 

    Use a script to update the list of `.proto` files use by each library,
as well as the list of libraries each library depends on.

The more complicated case was the `google-cloud-cpp::logging_type_protos`
library, its name does not match the Bazel rules where it would generate
`*logging_type_type_protos`. I introduced an `INTERFACE` library for
backwards compatibility.

In the bigquery library we are exposing both the `v1beta1/` and `v1/`
versions of `connection.proto`. I will figure out how to clean that up
in a future PR.
    @coryan
    coryan committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    8916209 View commit details
    Browse the repository at this point in the history

  2. Install headers and protos for google_cloud_cpp_logging_type_protos

    @coryan
    coryan committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    86a8721 View commit details
    Browse the repository at this point in the history

  3. Support older CMake versions

    @coryan
    coryan committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    fec79c7 View commit details
    Browse the repository at this point in the history

  4. Fix Bigtable deps

    @coryan
    coryan committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    62096ba View commit details
    Browse the repository at this point in the history