Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing dependency for WIN32 #7718

Merged
merged 1 commit into from
Dec 9, 2021

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Dec 9, 2021

We were missing a direct dependency on Windows. It probably went
unnoticed because in our tests we get this dependency indirectly. It is
important for Conda support.


This change is Reviewable

@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: 08cc053030a9218709cc781d6907e96ab8b62f7c

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

We were missing a direct dependency on Windows. It probably went
unnoticed because in our tests we get this dependency indirectly. It is
important for Conda support.
@coryan coryan force-pushed the fix-support-conda-packages-windows branch from 08cc053 to f15fa5e Compare December 9, 2021 15:34
@google-cloud-cpp-bot
Copy link
Collaborator

Google Cloud Build Logs
For commit: f15fa5ef8e0d272934580dd32a77e6b776842792

ℹ️ NOTE: Kokoro logs are linked from "Details" below.

@codecov
Copy link

codecov bot commented Dec 9, 2021

Codecov Report

Merging #7718 (f15fa5e) into main (cc5834b) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #7718   +/-   ##
=======================================
  Coverage   95.29%   95.30%           
=======================================
  Files        1256     1256           
  Lines      113697   113697           
=======================================
+ Hits       108350   108354    +4     
+ Misses       5347     5343    -4     
Impacted Files Coverage Δ
.../cloud/storage/benchmarks/throughput_experiment.cc 74.87% <0.00%> (+0.50%) ⬆️
...ud/spanner/integration_tests/client_stress_test.cc 86.18% <0.00%> (+0.65%) ⬆️
...bigtable/examples/bigtable_hello_instance_admin.cc 83.51% <0.00%> (+2.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc5834b...f15fa5e. Read the comment docs.

@coryan coryan marked this pull request as ready for review December 9, 2021 15:58
@coryan coryan requested a review from a team as a code owner December 9, 2021 15:58
@coryan coryan merged commit faff4cc into googleapis:main Dec 9, 2021
@coryan coryan deleted the fix-support-conda-packages-windows branch December 9, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants