Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(storage)!: uploads track committed_size #7868

Merged

Commits on Jan 10, 2022

  1. cleanup(storage)!: uploads track committed_size

    Fixing how the `storage` client library deals with reponses lacking a
    `Range` header will break any existing unit tests that mock a
    `ResumableUploadSession`. This creates an opportunity to cleanup the
    semantics of `ResumableUploadResponse`. This change performs that
    cleanup.
    
    **BREAKING CHANGE:** with this PR any use of the
    `storage::internal::ResumableUploadResponse` type require changes.
    Applications should have little need for this type, outside mocks, so
    the changes should not affect production code.
    
    Nevertheless, we apologize for the inconvenience, and while we would have
    preferred to avoid breaking changes, it was inevitable to introduce some
    breaking changes to fix a data loss bug.
    
    If you are affected by this change, we expect that any existing tests
    will fail to compile. This was an intentional choice, the semantics of
    some values are changing, we think it is better to have these issues
    detected at compile-time rather than during test execution.
    
    We have updated the examples to use the new mocks, and the release notes
    include more details on how to change any affected tests.
    coryan committed Jan 10, 2022
    Configuration menu
    Copy the full SHA
    53775b2 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2022

  1. Address review comments

    coryan committed Jan 11, 2022
    Configuration menu
    Copy the full SHA
    f0071bb View commit details
    Browse the repository at this point in the history