cleanup(storage)!: uploads track committed_size #7868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing how the `storage` client library deals with reponses lacking a `Range` header will break any existing unit tests that mock a `ResumableUploadSession`. This creates an opportunity to cleanup the semantics of `ResumableUploadResponse`. This change performs that cleanup. **BREAKING CHANGE:** with this PR any use of the `storage::internal::ResumableUploadResponse` type require changes. Applications should have little need for this type, outside mocks, so the changes should not affect production code. Nevertheless, we apologize for the inconvenience, and while we would have preferred to avoid breaking changes, it was inevitable to introduce some breaking changes to fix a data loss bug. If you are affected by this change, we expect that any existing tests will fail to compile. This was an intentional choice, the semantics of some values are changing, we think it is better to have these issues detected at compile-time rather than during test execution. We have updated the examples to use the new mocks, and the release notes include more details on how to change any affected tests.
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Codecov Report
@@ Coverage Diff @@
## main #7868 +/- ##
=======================================
Coverage 95.12% 95.12%
=======================================
Files 1285 1285
Lines 116163 116122 -41
=======================================
- Hits 110496 110457 -39
+ Misses 5667 5665 -2
Continue to review full report at Codecov.
|
devbww
approved these changes
Jan 11, 2022
CHANGELOG.md
Outdated
| } | ||
| ``` | ||
|
|
||
| That is, you need to re-order the fields **and** change increase the |
There was a problem hiding this comment.
s/change increase/increase/?
| // We expect a `Range:` header in the format described here: | ||
| // https://cloud.google.com/storage/docs/json_api/v1/how-tos/resumable-upload | ||
| // that is the value should match `bytes=0-[0-9]+`: | ||
|
|
There was a problem hiding this comment.
Opt nit: Remove blank line?
|
Google Cloud Build Logs
ℹ️ NOTE: Kokoro logs are linked from "Details" below. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing how the
storageclient library deals with reponses lacking aRangeheader will break any existing unit tests that mock aResumableUploadSession. This creates an opportunity to cleanup thesemantics of
ResumableUploadResponse. This change performs thatcleanup.
BREAKING CHANGE: with this PR any use of the
storage::internal::ResumableUploadResponsetype require changes.Applications should have little need for this type, outside mocks, so
the changes should not affect production code.
Nevertheless, we apologize for the inconvenience, and while we would have
preferred to avoid breaking changes, it was inevitable to introduce some
breaking changes to fix a data loss bug.
If you are affected by this change, we expect that any existing tests
will fail to compile. This was an intentional choice, the semantics of
some values are changing, we think it is better to have these issues
detected at compile-time rather than during test execution.
We have updated the examples to use the new mocks, and the release notes
include more details on how to change any affected tests.
Fixes #6880, part of the work for #7835
This change is