Skip to content

Commit

Permalink
test(bigquery): address flaky error probing test (#4280)
Browse files Browse the repository at this point in the history
Context:  Looks like error mapping for excessively sized requests is
getting remapped to a more appropriate error code.  Change expectations
so we allow either HTTP 400 or 413 errors.

Fixes: #4277 
Fixes: #4279 
Fixes: #4285
  • Loading branch information
shollyman committed Jun 22, 2021
1 parent bd012d1 commit d429446
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions bigquery/integration_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -1249,8 +1249,8 @@ func TestIntegration_InsertErrors(t *testing.T) {
if !ok {
t.Errorf("wanted googleapi.Error, got: %v", err)
}
if e.Code != http.StatusBadRequest {
t.Errorf("Wanted HTTP 400, got %d", e.Code)
if e.Code != http.StatusBadRequest && e.Code != http.StatusRequestEntityTooLarge {
t.Errorf("Wanted HTTP 400 or 413, got %d", e.Code)
}
}

Expand Down

0 comments on commit d429446

Please sign in to comment.