Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigquery: TestIntegration_InsertErrors failed #4279

Closed
flaky-bot bot opened this issue Jun 17, 2021 · 1 comment · Fixed by #4280
Closed

bigquery: TestIntegration_InsertErrors failed #4279

flaky-bot bot opened this issue Jun 17, 2021 · 1 comment · Fixed by #4280
Assignees
@shollyman
Labels
api: bigquery Issues related to the BigQuery API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented Jun 17, 2021

Note: #3612 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.

commit: 5a9c6ce
buildURL: Build Status, Sponge
status: failed

Test output
integration_test.go:1253: Wanted HTTP 400, got 413
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 17, 2021
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jun 17, 2021
@shollyman shollyman mentioned this issue Jun 17, 2021
Merged
@shollyman shollyman added priority: p2 Moderately-important priority. Fix may not be included in next release. and removed priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. labels Jun 17, 2021
@flaky-bot
Copy link
Author

flaky-bot bot commented Jun 18, 2021

Test passed for commit 24c4451 (Build Status, Sponge)! Closing this issue.

@flaky-bot flaky-bot bot closed this as completed Jun 18, 2021
@shollyman shollyman mentioned this issue Jun 18, 2021
Closed
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 22, 2021
@shollyman
test(bigquery): address flaky error probing test (#4280)
d429446 
Context:  Looks like error mapping for excessively sized requests is
getting remapped to a more appropriate error code.  Change expectations
so we allow either HTTP 400 or 413 errors.

Fixes: #4277 
Fixes: #4279 
Fixes: #4285
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shollyman shollyman

Labels
api: bigquery Issues related to the BigQuery API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(bigquery): address flaky error probing test shollyman/google-cloud-go
1 participant
@shollyman