Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

internal: can we have a correct library version instead of a date? #2749

Closed
hengfengli opened this issue Aug 19, 2020 · 3 comments
Closed

internal: can we have a correct library version instead of a date? #2749

hengfengli opened this issue Aug 19, 2020 · 3 comments
Assignees
@codyoss
Labels
in progress type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@hengfengli
Copy link
Contributor

Currently, the version of the entire client lib is pinned to a date:

google-cloud-go/internal/version/version.go

Lines 27 to 29 in e455ed5

// Repo is the current version of the client libraries in this
// repo. It should be a date in YYYYMMDD format.
const Repo = "20200817"
. This can be confusing when comparing to other language client libs.

What is the story/background behind this? Are we able to have a proper library version, e.g., 0.64.0, instead of a date?
@hengfengli hengfengli added triage me I really want to be triaged. priority: p2 Moderately-important priority. Fix may not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels Aug 19, 2020
@yoshi-automation yoshi-automation removed the triage me I really want to be triaged. label Aug 19, 2020
@codyoss
Copy link
Member

codyoss commented Aug 20, 2020

I don't have the context to why this is a date today, but I agree I think we can do better here. I will have to do a little research into what other languages are populating into this value. I assume a semver like v0.64.0.

@codyoss codyoss mentioned this issue Dec 9, 2020
Merged
@mohanli-ml mohanli-ml mentioned this issue Dec 15, 2020
Merged
@codyoss codyoss mentioned this issue Mar 31, 2021
Closed
@crwilcox
Copy link
Contributor

#3330 related

@codyoss codyoss added the status: investigating The issue is under investigation, which is determined to be non-trivial. label Oct 12, 2021
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Feb 10, 2022
@codyoss
feat(storage): add better version metadata to calls
5b82907 
Adding a new file that should be maintained auotmatically by
release-please.

Updates: googleapis#2749
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Feb 10, 2022
@codyoss
feat(storage): add better version metadata to calls
9268740 
Adding a new file that should be maintained auotmatically by
release-please.

Updates: googleapis#2749
@codyoss codyoss mentioned this issue Feb 10, 2022
Merged
codyoss added a commit that referenced this issue Feb 10, 2022
@codyoss
feat(storage): add better version metadata to calls (#5507)
13fe0bc 
Adding a new file that should be maintained auotmatically by
release-please.

Updates: #2749
@release-please release-please bot mentioned this issue Feb 10, 2022
Merged
@codyoss codyoss mentioned this issue Feb 11, 2022
Merged
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Feb 11, 2022
@codyoss
chore: bulk update version for manual
f8d6f87 
This changes bulk updates all manuals that has reference to the
old version.Repo that has been a long incorrect value. This new
version files will be maintained by release please.

Updates: googleapis#2749

feat(bigquery): add better version metadata to calls

feat(datastore): add better version metadata to calls

feat(errorreporting): add better version metadata to calls

feat(firestore): add better version metadata to calls

feat(logging): add better version metadata to calls

feat(profiler): add better version metadata to calls

feat(pubsub): add better version metadata to calls

feat(translate): add better version metadata to calls
@codyoss codyoss mentioned this issue Feb 11, 2022
Merged
@codyoss codyoss added in progress and removed priority: p2 Moderately-important priority. Fix may not be included in next release. status: investigating The issue is under investigation, which is determined to be non-trivial. labels Feb 11, 2022
@codyoss codyoss mentioned this issue Feb 11, 2022
Merged
codyoss added a commit that referenced this issue Feb 11, 2022
@codyoss
chore: bulk add version files (#5517)
17b36ea 
Add version files for clients with only autogenerated surfaces.
Still need to hook this into generated code. That will come later.
These changes were generated with a script that used
`go list somemod@latest` to detect current module version.

Updates: #2749

Changes:

feat(accessapproval): add file for tracking version

feat(accesscontextmanager): add file for tracking version

feat(aiplatform): add file for tracking version

feat(analytics): add file for tracking version

feat(apigateway): add file for tracking version

feat(apigeeconnect): add file for tracking version

feat(appengine): add file for tracking version

feat(area120): add file for tracking version

feat(artifactregistry): add file for tracking version

feat(asset): add file for tracking version

feat(assuredworkloads): add file for tracking version

feat(automl): add file for tracking version

feat(bigtable): add file for tracking version

feat(billing): add file for tracking version

feat(binaryauthorization): add file for tracking version

feat(channel): add file for tracking version

feat(cloudbuild): add file for tracking version

feat(clouddms): add file for tracking version

feat(cloudtasks): add file for tracking version

feat(compute): add file for tracking version

feat(contactcenterinsights): add file for tracking version

feat(container): add file for tracking version

feat(containeranalysis): add file for tracking version

feat(datacatalog): add file for tracking version

feat(dataflow): add file for tracking version

feat(datafusion): add file for tracking version

feat(datalabeling): add file for tracking version

feat(dataplex): add file for tracking version

feat(dataproc): add file for tracking version

feat(dataqna): add file for tracking version

feat(datastream): add file for tracking version

feat(deploy): add file for tracking version

feat(dialogflow): add file for tracking version

feat(dlp): add file for tracking version

feat(documentai): add file for tracking version

feat(domains): add file for tracking version

feat(essentialcontacts): add file for tracking version

feat(eventarc): add file for tracking version

feat(filestore): add file for tracking version

feat(firestore): add file for tracking version

feat(functions): add file for tracking version

feat(gaming): add file for tracking version

feat(gkeconnect): add file for tracking version

feat(gkehub): add file for tracking version

feat(grafeas): add file for tracking version

feat(gsuiteaddons): add file for tracking version

feat(iam): add file for tracking version

feat(iap): add file for tracking version

feat(ids): add file for tracking version

feat(iot): add file for tracking version

feat(kms): add file for tracking version

feat(language): add file for tracking version

feat(lifesciences): add file for tracking version

feat(managedidentities): add file for tracking version

feat(mediatranslation): add file for tracking version

feat(memcache): add file for tracking version

feat(metastore): add file for tracking version

feat(monitoring): add file for tracking version

feat(networkconnectivity): add file for tracking version

feat(networkmanagement): add file for tracking version

feat(networksecurity): add file for tracking version

feat(notebooks): add file for tracking version

feat(orchestration): add file for tracking version

feat(orgpolicy): add file for tracking version

feat(osconfig): add file for tracking version

feat(oslogin): add file for tracking version

feat(phishingprotection): add file for tracking version

feat(policytroubleshooter): add file for tracking version

feat(privatecatalog): add file for tracking version

feat(pubsublite): add file for tracking version

feat(recaptchaenterprise): add file for tracking version

feat(recommendationengine): add file for tracking version

feat(recommender): add file for tracking version

feat(redis): add file for tracking version

feat(resourcemanager): add file for tracking version

feat(resourcesettings): add file for tracking version

feat(retail): add file for tracking version

feat(scheduler): add file for tracking version

feat(secretmanager): add file for tracking version

feat(security): add file for tracking version

feat(securitycenter): add file for tracking version

feat(servicecontrol): add file for tracking version

feat(servicedirectory): add file for tracking version

feat(servicemanagement): add file for tracking version

feat(serviceusage): add file for tracking version

feat(shell): add file for tracking version

feat(spanner): add file for tracking version

feat(speech): add file for tracking version

feat(storagetransfer): add file for tracking version

feat(talent): add file for tracking version

feat(texttospeech): add file for tracking version

feat(tpu): add file for tracking version

feat(trace): add file for tracking version

feat(video): add file for tracking version

feat(videointelligence): add file for tracking version

feat(vision): add file for tracking version

feat(vmmigration): add file for tracking version

feat(vpcaccess): add file for tracking version

feat(webrisk): add file for tracking version

feat(websecurityscanner): add file for tracking version

feat(workflows): add file for tracking version
codyoss added a commit that referenced this issue Feb 11, 2022
@codyoss
chore: bulk update version for manual (#5516)
d1ad921 
This changes bulk updates all manuals that has reference to the
old version.Repo that has been a long incorrect value. This new
version files will be maintained by release please.

Updates: #2749

feat(bigquery): add better version metadata to calls

feat(datastore): add better version metadata to calls

feat(errorreporting): add better version metadata to calls

feat(firestore): add better version metadata to calls

feat(logging): add better version metadata to calls

feat(profiler): add better version metadata to calls

feat(pubsub): add better version metadata to calls

feat(translate): add better version metadata to calls
codyoss added a commit that referenced this issue Feb 14, 2022
@codyoss
feat(spanner): add better version metadata to calls (#5515)
dcab7c4 
This new version file will automatically be maintained by release-please.
We just landed a similar change in storage recently in #5507. This
will be rolling out to all modules soon.

Fixes: #5515
Updates: #2749
@release-please release-please bot mentioned this issue Feb 14, 2022
Closed
@codyoss
Copy link
Member

codyoss commented Feb 22, 2022

I think this issue is for the most part complete. I would like to also get this hooked into the GAPIC layer more, but that will happen outside of this repo. Closing this issue for now as the original request of having better data in the manual is now true.

@codyoss codyoss closed this as completed Feb 22, 2022
@release-please release-please bot mentioned this issue Mar 2, 2022
Closed
@release-please release-please bot mentioned this issue Mar 3, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@codyoss codyoss

Labels
in progress type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@crwilcox @hengfengli @codyoss @yoshi-automation