Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bigtable: Make user agent the same as library version #3330

Closed
mohanli-ml opened this issue Dec 2, 2020 · 1 comment · Fixed by #5679
Closed

bigtable: Make user agent the same as library version #3330

mohanli-ml opened this issue Dec 2, 2020 · 1 comment · Fixed by #5679
Assignees
@dmahugh
Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@mohanli-ml
Copy link
Contributor

Currently the user agent of Bigtable in Go is standalone, as in https://github.com/googleapis/google-cloud-go/blob/master/bigtable/doc.go#L121m. Ideally, the user agent should be the same as the library release, which is v1.6.0 currently, see https://pkg.go.dev/cloud.google.com/go/bigtable.
@mohanli-ml mohanli-ml added the triage me I really want to be triaged. label Dec 2, 2020
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Dec 2, 2020
@kolea2 kolea2 added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. and removed triage me I really want to be triaged. labels Dec 2, 2020
@mohanli-ml mohanli-ml mentioned this issue Dec 9, 2020
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Dec 17, 2020
@mohanli-ml
bigtable: Update user-agent to the latest version (#3429)
81fc2d1 
Currently the user agent of Bigtable in Go is standalone, as in https://github.com/googleapis/google-cloud-go/blob/master/bigtable/doc.go#L121m. Update it to the latest version https://pkg.go.dev/cloud.google.com/go/bigtable. Related issue: #3330.

Background: DirectPath will use user agent to deny a specific library version, so we want to update the user agent with the library release date.
@tritone tritone assigned crwilcox and unassigned tritone Jan 22, 2021
@jimfulton
Copy link
Contributor

The fix in #3429 has rotted. IDK enough about the release process to know how to automate this and prevent rot, however

Why should the user agent and server versions be in sync?

@crwilcox crwilcox mentioned this issue Aug 30, 2021
Closed
@crwilcox crwilcox assigned dmahugh and unassigned crwilcox Nov 1, 2021
codyoss added a commit to codyoss/google-cloud-go that referenced this issue Feb 22, 2022
@codyoss
fix(bigtable): use internal.Version that is auto-updated for UA
69d9f00 
Fixes: googleapis#3330
@codyoss codyoss mentioned this issue Feb 22, 2022
Merged
codyoss added a commit that referenced this issue Feb 22, 2022
@codyoss
fix(bigtable): use internal.Version that is auto-updated for UA (#5679)
bd2c600 
Fixes: #3330
@release-please release-please bot mentioned this issue Feb 22, 2022
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue May 26, 2022
@release-please
chore(main): release bigtable 1.14.0 (#5614)
a00d00d 
🤖 I have created a release *beep* *boop*
---


## [1.14.0](bigtable/v1.13.0...bigtable/v1.14.0) (2022-05-26)


### Features

* **bigtable:** add file for tracking version ([17b36ea](17b36ea))
* **bigtable:** loadtest support app profile ([#5882](#5882)) ([ec00e5a](ec00e5a))
* **bigtable:** support PingAndWarm in emulator ([#5803](#5803)) ([9b943d5](9b943d5))


### Bug Fixes

* **bigtable:** use internal.Version that is auto-updated for UA ([#5679](#5679)) ([bd2c600](bd2c600)), refs [#3330](#3330)

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
@release-please release-please bot mentioned this issue May 26, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dmahugh dmahugh

Labels
api: bigtable Issues related to the Bigtable API. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(bigtable): use internal.Version that is auto-updated for UA codyoss/google-cloud-go
6 participants
@crwilcox @jimfulton @dmahugh @tritone @kolea2 @mohanli-ml