feat(bigtable): support PingAndWarm in emulator #5803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbolduc
requested review from
igorbernstein2,
a team,
dmahugh,
tritone and
telpirion
as code owners
product-auto-label
bot
added
size: xs
telpirion
approved these changes
Mar 30, 2022
product-auto-label
bot
added
size: s
product-auto-label
bot
added
the
stale: old
telpirion
added
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
gcf-merge-on-green
bot
removed
the
automerge
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
May 26, 2022
🤖 I have created a release *beep* *boop* --- ## [1.14.0](bigtable/v1.13.0...bigtable/v1.14.0) (2022-05-26) ### Features * **bigtable:** add file for tracking version ([17b36ea](17b36ea)) * **bigtable:** loadtest support app profile ([#5882](#5882)) ([ec00e5a](ec00e5a)) * **bigtable:** support PingAndWarm in emulator ([#5803](#5803)) ([9b943d5](9b943d5)) ### Bug Fixes * **bigtable:** use internal.Version that is auto-updated for UA ([#5679](#5679)) ([bd2c600](bd2c600)), refs [#3330](#3330) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5802
I do not check that the instance is in
s.instances, because there is no way to create an instance. I do not think we want to require that users callCreateInstancebeforeCreateTable, so we probably do not want to require that users callCreateInstancebeforePingAndWarmeither.