-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
storage: TestIntegration_ACL failed #6579
Comments
Looks like this issue is flaky. 😟 I'm going to leave this open and stop commenting. A human should fix and close this. When run at the same commit (c220ca2), this test passed in one build (Build Status, Sponge) and failed in another build (Build Status, Sponge). |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 9f3c334 Test outputintegration_test.go:2377: hasRule: object ACL missing {Entity:domain-google.com EntityID: Role:READER Domain:google.com Email: ProjectTeam:} integration_test.go:2381: object ACL: could not delete entity domain-google.com |
Previously the docs said that these operations would take effect within 10s, but I noticed that at some point this was loosened up to "at least 30s" and "about a minute" depending on the location. I think these tests will still usually run in a similar amount of time, but hopefully extending this timeout will avoid some flakes. https://cloud.google.com/storage/docs/consistency#eventually_consistent_operations https://cloud.google.com/storage/docs/access-control/lists#modification-rules (see note above) Fixes googleapis#6579
Previously the docs said that these operations would take effect within 10s, but I noticed that at some point this was loosened up to "at least 30s" and "about a minute" depending on the location. I think these tests will still usually run in a similar amount of time, but hopefully extending this timeout will avoid some flakes. https://cloud.google.com/storage/docs/consistency#eventually_consistent_operations https://cloud.google.com/storage/docs/access-control/lists#modification-rules (see note above) Fixes #6579
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 5733a42 Test outputintegration_test.go:2377: hasRule: object ACL missing {Entity:domain-google.com EntityID: Role:READER Domain:google.com Email: ProjectTeam:} integration_test.go:2381: object ACL: could not delete entity domain-google.com |
Latest failure was from a commit before my fix was merged. Therefore I'm going to close this again. |
Oops! Looks like this issue is still flaky. It failed again. 😬 I reopened the issue, but a human will need to close it again. commit: 1ad1aba Test outputintegration_test.go:2377: hasRule: object ACL missing {Entity:domain-google.com EntityID: Role:READER Domain:google.com Email: ProjectTeam:} integration_test.go:2381: object ACL: could not delete entity domain-google.com |
I realized that this section had been slightly messed up in the integration test refactor for retries; we need the object creation to be retried as well if the check fails. Also removed superfluous unused object name. Fixes googleapis#6579
I realized that this section had been slightly messed up in the integration test refactor for retries; we need the object creation to be retried as well if the check fails. Also removed superfluous unused object name. Fixes #6579
Note: #6379 was also for this test, but it was closed more than 10 days ago. So, I didn't mark it flaky.
commit: c220ca2
buildURL: Build Status, Sponge
status: failed
Test output
The text was updated successfully, but these errors were encountered: