test(storage): increase timeout for ACL test retry #6618
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the docs said that these operations would take effect within 10s, but I noticed that at some point this was loosened up to "at least 30s" and "about a minute" depending on the location. I think these tests will still usually run in a similar amount of time, but hopefully extending this timeout will avoid some flakes. https://cloud.google.com/storage/docs/consistency#eventually_consistent_operations https://cloud.google.com/storage/docs/access-control/lists#modification-rules (see note above) Fixes googleapis#6579
product-auto-label
bot
added
size: xs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the docs said that these operations would take effect
within 10s, but I noticed that at some point this was loosened
up to "at least 30s" and "about a minute" depending on the
location. I think these tests will still usually run in a similar
amount of time, but hopefully extending this timeout will avoid
some flakes.
https://cloud.google.com/storage/docs/consistency#eventually_consistent_operations
https://cloud.google.com/storage/docs/access-control/lists#modification-rules
(see note above)
Fixes #6579