Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(spanner): support RPC priority for partition query #3896

Closed
wants to merge 1 commit into from
Closed

feat(spanner): support RPC priority for partition query #3896

wants to merge 1 commit into from

Conversation

yfuruyama
Copy link
Contributor

RPC priority was added by #3341, but it looks like the partition (batch) query was not supported in that PR.

This PR is for supporting RPC priority for the partition query.

This graph shows the CPU usage for low priority when I used this fix for running a partition query.
image

@yfuruyama yfuruyama requested review from skuruppu and a team as code owners April 7, 2021 10:48
@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Apr 7, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Apr 7, 2021
@skuruppu skuruppu requested a review from olavloite April 8, 2021 00:34
@olavloite
Copy link
Contributor

@yfuruyama Thanks for reporting this. That's indeed an omission. There's however a couple of other requests there as well that need to be updated, as this PR only covers queries and not read operations. I'll add an additional PR that covers that as well and reference this.

@yfuruyama
Copy link
Contributor Author

@olavloite Oops, sorry I should have asked you before creating this. Sure, I'll close this PR for now and look forward to seeing your PR :)

@yfuruyama yfuruyama closed this Apr 8, 2021
@olavloite
Copy link
Contributor

@olavloite Oops, sorry I should have asked you before creating this. Sure, I'll close this PR for now and look forward to seeing your PR :)

Absolutely nothing to be sorry for :-) This PR made it clear right away what is missing.

@olavloite olavloite mentioned this pull request Apr 8, 2021
Closed
olavloite added a commit that referenced this pull request Apr 8, 2021
@olavloite
feat(spanner): enable request options for batch read
aafb687 
Enables RequestOptions (priority and tagging) for batch read transactions.
This problem was first reported in #3896.

Fixes #3904
@olavloite olavloite mentioned this pull request Apr 8, 2021
Merged
skuruppu pushed a commit that referenced this pull request Apr 21, 2021
@olavloite
feat(spanner): enable request options for batch read (#3905)
0c73db2 
Enables RequestOptions (priority and tagging) for batch read transactions.
This problem was first reported in #3896.

Fixes #3904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skuruppu skuruppu Awaiting requested review from skuruppu

@olavloite olavloite Awaiting requested review from olavloite

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yfuruyama @olavloite