feat(spanner): enable request options for batch read #3905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
hengfengli
reviewed
Apr 9, 2021
There was a problem hiding this comment.
LGTM. @skuruppu But do we need to hold off this change because it is related to tagging?
|
I think because the PR is already merged for tagging, we should merge this in for completeness. |
hengfengli
approved these changes
Apr 9, 2021
olavloite
added
the
automerge
gcf-merge-on-green
bot
removed
the
automerge
|
@skuruppu Apparently this PR can only be merged once a code owner has approved. |
olavloite
added a commit
that referenced
this pull request
Apr 22, 2021
This reverts commit 0c73db2.
olavloite
added a commit
that referenced
this pull request
Apr 22, 2021
BREAKING CHANGE: Removes - BatchReadOnlyTransaction.PartitionReadUsingIndexWithOptions - BatchReadOnlyTransaction.PartitionReadWithOptions This reverts commit 0c73db2.
olavloite
added a commit
that referenced
this pull request
Apr 22, 2021
olavloite
added a commit
that referenced
this pull request
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables RequestOptions (priority and tagging) for batch read transactions. This problem was first reported in #3896.
cc @yfuruyama
Fixes #3904