Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datastore upgrade before Sep 30th #1291

Closed
lahirug opened this issue Sep 28, 2016 · 5 comments
Closed

Datastore upgrade before Sep 30th #1291

lahirug opened this issue Sep 28, 2016 · 5 comments
Assignees
@mziccard

Comments

@lahirug
Copy link

lahirug commented Sep 28, 2016

We are using dataflow api with protobuf and google api's like datastore, ads, bigquery and lot more other apis. Now we got an email to update the datastore-api to v1 (currrently using protobuf 2.6.1 and other v1beta2: datastore).

I see lot of different versions of datastore and I'm not sure what exact version to use ?

I just picked one and updated all the places which gave me compilation errors and when I try to run it in GCE I hit #1239 .

Is there a migration guide for datastore ? I'm curious even if I migrate datastore would all these work with a new protobuf version suggested in #1239 . If we have other apis working together in dataflow pipeline what is the best way to do this migration ?
@mziccard
Copy link
Contributor

mziccard commented Sep 29, 2016 •
edited
Loading

Hi @lahirug, thanks for your interest in google-cloud.

google-cloud-datastore uses datastore v1 since version 0.2.8 (under the previous name gcloud-java-datastore - see release notes). Issue #1239 is now fixed in google-cloud-datastore 0.4.0. I suggest you try our latest version and keep us posted :)

@lahirug
Copy link
Author

lahirug commented Sep 29, 2016

@mziccard Thanks for the response. I tried using and I got the same error as #1239 but the solution/workaround for that issue involves using protobuf-java: 3.0.0 (If I understood correct) and moving to protobuf-java: 3.0.0 is going to be a very big change for us.

Of when you say #1239 is now fixed is it fixed properly in some jar ? If thats the case which jar should I be using ?
Before posting this issue I tried using datastore-v1-proto-client:1.2.0 and datastore-v1-protos:1.2.0 with protobuf-java: 2.6.1 and I saw some classes are missing which I need to use in datastore (ex: Int32Value), so I gave up that too.

@mziccard
Copy link
Contributor

Let's make some order here.

This repository hosts the google-cloud project which is a Java-idiomatic client for Google Cloud Platform, amongst which we have google-cloud-datastore that supports Datastore. google-cloud-datastore depends on datastore-v1-proto-client and datastore-v1-protos to do its job.

#1239 is being experienced by people already using protobuf-java 3.0.0 and depending on google-cloud < 0.4.0 which required protobuf-java 3.0.0-beta3, oddly not compatible with 3.0.0. If you are stuck to protobuf-java 2.6.1 you are experiencing a compatibility issue but not the one reported in #1239.

All datastore-v1-proto-client and datastore-v1-protos versions that run against Datastore v1 require protobuf-java 3.0.0-beta3 or protobuf-java 3.0.0 which are not compatible with your protobuf-java 2.6.1.

You could avoid including datastore-v1-protos and try generating Datastore v1 protos for your version of protobuf-java, but I am not sure whether this is possible. \cc @eddavisson @pcostell

@eddavisson
Copy link

datastore-v1-protos uses proto3 features (e.g. maps), so I don't believe it can be compiled with protobuf-java 2.6.1.

@mziccard
Copy link
Contributor

mziccard commented Oct 4, 2016

I am closing this as it seems there's nothing we can do to help. @lahirug you'll probably have to update your protobuf version.

@mziccard mziccard closed this as completed Oct 4, 2016
github-actions bot pushed a commit that referenced this issue Aug 9, 2022
@renovate-bot
deps: update dependency com.google.cloud:google-cloud-storage to v2.1…
3af9102 
…1.1 (#1291)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-storage](https://github.com/googleapis/java-storage) | `2.11.0` -> `2.11.1` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/compatibility-slim/2.11.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-storage/2.11.1/confidence-slim/2.11.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-storage</summary>

### [`v2.11.1`](https://github.com/googleapis/java-storage/blob/HEAD/CHANGELOG.md#&#8203;2111-httpsgithubcomgoogleapisjava-storagecomparev2110v2111-2022-08-04)

[Compare Source](https://github.com/googleapis/java-storage/compare/v2.11.0...v2.11.1)

##### Dependencies

-   update dependency com.google.cloud:google-cloud-pubsub to v1.120.9 ([#&#8203;1537](https://github.com/googleapis/java-storage/issues/1537)) ([ae17737](https://github.com/googleapis/java-storage/commit/ae17737342e262f7afd404e4c758a7fbf5530da5))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-asset).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4xNDMuMSIsInVwZGF0ZWRJblZlciI6IjMyLjE0My4xIn0=-->
github-actions bot pushed a commit that referenced this issue Aug 9, 2022
@release-please
chore(main): release 3.5.0 (#1305)
974924f 
🤖 I have created a release *beep* *boop*
---


## [3.5.0](googleapis/java-asset@v3.4.2...v3.5.0) (2022-08-09)


### Features

* Remove v1p4beta1 API protos. v1p4beta1 has been deprecated and announced through MSA. This is the cleanup ([ebab5c6](googleapis/java-asset@ebab5c6))


### Dependencies

* update dependency com.google.api.grpc:proto-google-cloud-orgpolicy-v1 to v2.3.0 ([#1257](googleapis/java-asset#1257)) ([c61c0e8](googleapis/java-asset@c61c0e8))
* update dependency com.google.api.grpc:proto-google-cloud-os-config-v1 to v2.5.1 ([#1279](googleapis/java-asset#1279)) ([5995764](googleapis/java-asset@5995764))
* update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.10 ([#1292](googleapis/java-asset#1292)) ([76f886e](googleapis/java-asset@76f886e))
* update dependency com.google.api.grpc:proto-google-cloud-pubsub-v1 to v1.102.9 ([#1280](googleapis/java-asset#1280)) ([a35d490](googleapis/java-asset@a35d490))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.0 ([#1272](googleapis/java-asset#1272)) ([60763d4](googleapis/java-asset@60763d4))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.1 ([#1274](googleapis/java-asset#1274)) ([8b4efa5](googleapis/java-asset@8b4efa5))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.2 ([#1294](googleapis/java-asset#1294)) ([ff76d3a](googleapis/java-asset@ff76d3a))
* update dependency com.google.cloud:google-cloud-bigquery to v2.14.3 ([#1296](googleapis/java-asset#1296)) ([4c2a6ec](googleapis/java-asset@4c2a6ec))
* update dependency com.google.cloud:google-cloud-core to v2.8.3 ([#1273](googleapis/java-asset#1273)) ([1ad7821](googleapis/java-asset@1ad7821))
* update dependency com.google.cloud:google-cloud-core to v2.8.4 ([#1275](googleapis/java-asset#1275)) ([a45d90c](googleapis/java-asset@a45d90c))
* update dependency com.google.cloud:google-cloud-core to v2.8.5 ([#1276](googleapis/java-asset#1276)) ([985d6e6](googleapis/java-asset@985d6e6))
* update dependency com.google.cloud:google-cloud-core to v2.8.6 ([#1283](googleapis/java-asset#1283)) ([26f527c](googleapis/java-asset@26f527c))
* update dependency com.google.cloud:google-cloud-core to v2.8.7 ([#1285](googleapis/java-asset#1285)) ([fe40190](googleapis/java-asset@fe40190))
* update dependency com.google.cloud:google-cloud-core to v2.8.8 ([#1288](googleapis/java-asset#1288)) ([566e032](googleapis/java-asset@566e032))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.1 ([#1229](googleapis/java-asset#1229)) ([dcc463c](googleapis/java-asset@dcc463c))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.10 ([#1293](googleapis/java-asset#1293)) ([d6188ca](googleapis/java-asset@d6188ca))
* update dependency com.google.cloud:google-cloud-pubsub to v1.120.9 ([#1281](googleapis/java-asset#1281)) ([79d5a3c](googleapis/java-asset@79d5a3c))
* update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.0 ([#1261](googleapis/java-asset#1261)) ([1cca78c](googleapis/java-asset@1cca78c))
* update dependency com.google.cloud:google-cloud-resourcemanager to v1.5.2 ([#1287](googleapis/java-asset#1287)) ([a399744](googleapis/java-asset@a399744))
* update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([#1277](googleapis/java-asset#1277)) ([7a27f49](googleapis/java-asset@7a27f49))
* update dependency com.google.cloud:google-cloud-storage to v2.10.0 ([#1282](googleapis/java-asset#1282)) ([66ba2ad](googleapis/java-asset@66ba2ad))
* update dependency com.google.cloud:google-cloud-storage to v2.11.0 ([#1286](googleapis/java-asset#1286)) ([4df8988](googleapis/java-asset@4df8988))
* update dependency com.google.cloud:google-cloud-storage to v2.11.1 ([#1291](googleapis/java-asset#1291)) ([3af9102](googleapis/java-asset@3af9102))
* update dependency com.google.cloud:google-cloud-storage to v2.11.2 ([#1295](googleapis/java-asset#1295)) ([693d42b](googleapis/java-asset@693d42b))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Oct 10, 2022
@release-please
chore(main): release 2.3.19-SNAPSHOT (#1291)
124714e 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mziccard mziccard

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mziccard @eddavisson @lahirug