Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wording for updateSink is confusing #473

Closed
pongad opened this issue Dec 17, 2015 · 1 comment
Closed

Wording for updateSink is confusing #473

pongad opened this issue Dec 17, 2015 · 1 comment
Assignees
Labels
api: logging Issues related to the Cloud Logging API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@pongad
Copy link
Contributor

pongad commented Dec 17, 2015

"If the sink doesn't exist, it is created". This means it's possible to "update" a sink that doesn't exist. The user must still provide the sink to the method.

@aozarov aozarov added the api: logging Issues related to the Cloud Logging API. label Dec 17, 2015
@aozarov aozarov added this to the Logging Stable milestone Dec 17, 2015
@garrettjonesgoogle
Copy link
Member

The wording is currently "Updates or creates a sink." I think this is fine.

@yoshi-automation yoshi-automation added triage me I really want to be triaged. 🚨 This issue needs some love. labels Apr 6, 2020
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
…2.0 (googleapis#473)

[![WhiteSource Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:libraries-bom](https://github.com/GoogleCloudPlatform/cloud-opensource-java) | `20.1.0` -> `20.2.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.2.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.2.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.2.0/compatibility-slim/20.1.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:libraries-bom/20.2.0/confidence-slim/20.1.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

:date: **Schedule**: At any time (no schedule defined).

:vertical_traffic_light: **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

:recycle: **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

:no_bell: **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box.

---

This PR has been generated by [WhiteSource Renovate](https://renovate.whitesourcesoftware.com). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-resourcemanager).
github-actions bot pushed a commit that referenced this issue Jul 1, 2022
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Jul 14, 2022
Source-Link: googleapis/synthtool@7336562
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:d4b80feffe1579818cdc39466152e9de95789a193408506cd4a1ffbe8804dc00
github-actions bot pushed a commit that referenced this issue Jul 14, 2022
🤖 I have created a release *beep* *boop*
---


## [2.3.1](googleapis/java-workflows@v2.3.0...v2.3.1) (2022-07-13)


### Bug Fixes

* enable longpaths support for windows test ([#1485](https://github.com/googleapis/java-workflows/issues/1485)) ([#473](googleapis/java-workflows#473)) ([8d45b91](googleapis/java-workflows@8d45b91))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Aug 25, 2022
- [ ] Regenerate this pull request now.

Committer: @ketanbshah
PiperOrigin-RevId: 469606602

Source-Link: googleapis/googleapis@32d2f9b

Source-Link: https://github.com/googleapis/googleapis-gen/commit/f87e8520136640f768cc2e42d9c56ca4def229f4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjg3ZTg1MjAxMzY2NDBmNzY4Y2MyZTQyZDljNTZjYTRkZWYyMjlmNCJ9
github-actions bot pushed a commit that referenced this issue Sep 19, 2022
🤖 I have created a release *beep* *boop*
---


## [2.2.0](googleapis/java-assured-workloads@v2.1.0...v2.2.0) (2022-09-15)


### Features

* Add compliant_but_disallowed_services field to the v1beta1 Workload proto ([#476](googleapis/java-assured-workloads#476)) ([cbcb55d](googleapis/java-assured-workloads@cbcb55d))
* Updated v1beta1 analyzeWorkloadMove documentation ([#473](googleapis/java-assured-workloads#473)) ([903257b](googleapis/java-assured-workloads@903257b))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#478](googleapis/java-assured-workloads#478)) ([c646513](googleapis/java-assured-workloads@c646513))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#480](googleapis/java-assured-workloads#480)) ([a48cd73](googleapis/java-assured-workloads@a48cd73))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
🤖 I have created a release *beep* *boop*
---


## [0.13.3](googleapis/java-analytics-admin@v0.13.2...v0.13.3) (2022-09-29)


### Dependencies

* Update dependency cachetools to v5 ([#478](googleapis/java-analytics-admin#478)) ([1231930](googleapis/java-analytics-admin@1231930))
* Update dependency certifi to v2022.9.24 ([#460](googleapis/java-analytics-admin#460)) ([ec8852d](googleapis/java-analytics-admin@ec8852d))
* Update dependency charset-normalizer to v2.1.1 ([#464](googleapis/java-analytics-admin#464)) ([7aded8b](googleapis/java-analytics-admin@7aded8b))
* Update dependency click to v8.1.3 ([#465](googleapis/java-analytics-admin#465)) ([2ad11fb](googleapis/java-analytics-admin@2ad11fb))
* Update dependency gcp-releasetool to v1.8.8 ([#461](googleapis/java-analytics-admin#461)) ([52bcec4](googleapis/java-analytics-admin@52bcec4))
* Update dependency google-api-core to v2.10.1 ([#466](googleapis/java-analytics-admin#466)) ([f5f28e4](googleapis/java-analytics-admin@f5f28e4))
* Update dependency google-auth to v2.12.0 ([#467](googleapis/java-analytics-admin#467)) ([b96c8a3](googleapis/java-analytics-admin@b96c8a3))
* Update dependency google-cloud-core to v2.3.2 ([#462](googleapis/java-analytics-admin#462)) ([b444b65](googleapis/java-analytics-admin@b444b65))
* Update dependency google-cloud-storage to v2.5.0 ([#468](googleapis/java-analytics-admin#468)) ([620097f](googleapis/java-analytics-admin@620097f))
* Update dependency google-crc32c to v1.5.0 ([#469](googleapis/java-analytics-admin#469)) ([3f39cda](googleapis/java-analytics-admin@3f39cda))
* Update dependency googleapis-common-protos to v1.56.4 ([#463](googleapis/java-analytics-admin#463)) ([0fbc166](googleapis/java-analytics-admin@0fbc166))
* Update dependency importlib-metadata to v4.12.0 ([#470](googleapis/java-analytics-admin#470)) ([cc0108c](googleapis/java-analytics-admin@cc0108c))
* Update dependency jeepney to v0.8.0 ([#471](googleapis/java-analytics-admin#471)) ([1d09acc](googleapis/java-analytics-admin@1d09acc))
* Update dependency jinja2 to v3.1.2 ([#472](googleapis/java-analytics-admin#472)) ([9949a07](googleapis/java-analytics-admin@9949a07))
* Update dependency keyring to v23.9.3 ([#473](googleapis/java-analytics-admin#473)) ([443e7df](googleapis/java-analytics-admin@443e7df))
* Update dependency markupsafe to v2.1.1 ([#480](googleapis/java-analytics-admin#480)) ([ddebd04](googleapis/java-analytics-admin@ddebd04))
* Update dependency protobuf to v3.20.2 ([#481](googleapis/java-analytics-admin#481)) ([f0f032f](googleapis/java-analytics-admin@f0f032f))
* Update dependency protobuf to v4 ([#479](googleapis/java-analytics-admin#479)) ([754bb78](googleapis/java-analytics-admin@754bb78))
* Update dependency pyjwt to v2.5.0 ([#474](googleapis/java-analytics-admin#474)) ([6777481](googleapis/java-analytics-admin@6777481))
* Update dependency requests to v2.28.1 ([#475](googleapis/java-analytics-admin#475)) ([48dc786](googleapis/java-analytics-admin@48dc786))
* Update dependency typing-extensions to v4.3.0 ([#476](googleapis/java-analytics-admin#476)) ([8835380](googleapis/java-analytics-admin@8835380))
* Update dependency zipp to v3.8.1 ([#477](googleapis/java-analytics-admin#477)) ([3f004ad](googleapis/java-analytics-admin@3f004ad))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Oct 4, 2022
🤖 I have created a release *beep* *boop*
---


## [2.5.3](https://github.com/googleapis/java-functions/compare/v2.5.2...v2.5.3) (2022-10-03)


### Dependencies

* Update dependency certifi to v2022.9.24 ([#472](https://github.com/googleapis/java-functions/issues/472)) ([7b30732](https://github.com/googleapis/java-functions/commit/7b30732c6359a827616aed1dba184544df95ec37))
* Update dependency charset-normalizer to v2.1.1 ([#479](https://github.com/googleapis/java-functions/issues/479)) ([059a126](https://github.com/googleapis/java-functions/commit/059a1268254468b2b86950ad7d0ca8b4d4446d60))
* Update dependency click to v8.1.3 ([#480](https://github.com/googleapis/java-functions/issues/480)) ([808075d](https://github.com/googleapis/java-functions/commit/808075d9b02a6aa3bc7ad5ec94d6dc9b94cc2588))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#497](https://github.com/googleapis/java-functions/issues/497)) ([f8ac08b](https://github.com/googleapis/java-functions/commit/f8ac08b604a81f544a55e82f45cb540f6cf44638))
* Update dependency gcp-releasetool to v1.8.8 ([#477](https://github.com/googleapis/java-functions/issues/477)) ([5bbe57f](https://github.com/googleapis/java-functions/commit/5bbe57f388219a8d0e058a4199e9f5abf457e3a2))
* Update dependency google-api-core to v2.10.1 ([#481](https://github.com/googleapis/java-functions/issues/481)) ([05b981c](https://github.com/googleapis/java-functions/commit/05b981c68f17497993059c3cc082c8b854c82dc8))
* Update dependency google-cloud-core to v2.3.2 ([#473](https://github.com/googleapis/java-functions/issues/473)) ([70370a5](https://github.com/googleapis/java-functions/commit/70370a5883ee497d5934e9c874653fab6e692468))
* Update dependency importlib-metadata to v4.12.0 ([#482](https://github.com/googleapis/java-functions/issues/482)) ([bab4cb5](https://github.com/googleapis/java-functions/commit/bab4cb59880f91c8dd93e3ff07ac6152844744f2))
* Update dependency jeepney to v0.8.0 ([#483](https://github.com/googleapis/java-functions/issues/483)) ([ddb1529](https://github.com/googleapis/java-functions/commit/ddb1529c5f631703e047634b9c09e516c6ce16e8))
* Update dependency keyring to v23.9.3 ([#485](https://github.com/googleapis/java-functions/issues/485)) ([856993e](https://github.com/googleapis/java-functions/commit/856993e803c18331bed2e9c2576f4182694380b3))
* Update dependency markupsafe to v2.1.1 ([#486](https://github.com/googleapis/java-functions/issues/486)) ([bb11c09](https://github.com/googleapis/java-functions/commit/bb11c09a578191ea6b770b0b055474101f8462bb))
* Update dependency protobuf to v3.20.2 ([#487](https://github.com/googleapis/java-functions/issues/487)) ([875c9c2](https://github.com/googleapis/java-functions/commit/875c9c2a3e77010a0ba6052a23454c40a1349c4f))
* Update dependency typing-extensions to v4.3.0 ([#490](https://github.com/googleapis/java-functions/issues/490)) ([4b2af03](https://github.com/googleapis/java-functions/commit/4b2af03c457600c4e840e0a355d71200088b6096))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this issue Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Development

No branches or pull requests

4 participants