Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

writeLogEntries: what happens if no logName is provided? #475

Closed
pongad opened this issue Dec 17, 2015 · 4 comments
Closed

writeLogEntries: what happens if no logName is provided? #475

pongad opened this issue Dec 17, 2015 · 4 comments
Assignees
@jabubake
Labels
api: core api: logging Issues related to the Cloud Logging API. 🚨 This issue needs some love. triage me I really want to be triaged.

Comments

@pongad
Copy link
Contributor

pongad commented Dec 17, 2015

No description provided.

@pongad pongad mentioned this issue Dec 17, 2015
Merged
@aozarov aozarov added the api: logging Issues related to the Cloud Logging API. label Dec 17, 2015
@aozarov aozarov added this to the Logging Stable milestone Dec 17, 2015
@lesv
Copy link
Contributor

lesv commented Feb 27, 2017

@jabubake Can you try this and tell us the results.

@jabubake
Copy link
Contributor

jabubake commented Mar 1, 2017

Logs are not written out when no filename is specified, it gets blocked but no exception is thrown.
We require a Preconditions.checkNotNull and a <default-log-name>

@michaelbausor
Copy link
Contributor

@jabubake I am not finding the same issue - what can I do to reproduce?

I am finding that if the log name is set to null in LoggingHandler then the default value of "java.log" is used. There is an error case if the user sets the log name to an empty string, which is guaranteed to fail.

And if you use the generated LoggingClient directly, we get an exception back from the service, which is what we expect.

@jabubake
Copy link
Contributor

@michaelbausor : retested, looks like this is fine. I am seeing the exception, I think my test was incorrect earlier.
With the generated LoggingClient, I am seeing : Exception in thread "main" com.google.cloud.logging.LoggingException: io.grpc.StatusRuntimeException: INVALID_ARGUMENT
Code used to test : https://github.com/GoogleCloudPlatform/java-docs-samples/blob/master/logging/cloud-client/src/main/java/com/example/logging/QuickstartSample.java

@yoshi-automation yoshi-automation added 🚨 This issue needs some love. triage me I really want to be triaged. labels Apr 6, 2020
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
@yoshi-automation
chore: regenerate README (googleapis#475)
a50dbe2 
This PR was generated using Autosynth. 🌈


<details><summary>Log from Synthtool</summary>

```
2021-04-30 18:21:49,270 synthtool [DEBUG] > Executing /root/.cache/synthtool/java-resourcemanager/.github/readme/synth.py.
On branch autosynth-readme
nothing to commit, working tree clean
2021-04-30 18:21:50,380 synthtool [DEBUG] > Wrote metadata to .github/readme/synth.metadata/synth.metadata.

```
</details>

Full log will be available here:
https://source.cloud.google.com/results/invocations/c8e2bb51-5e31-469d-8ebd-df2deba9c378/targets

- [ ] To automatically regenerate this PR, check this box. (May take up to 24 hours.)
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jun 29, 2022
@gcf-owl-bot
fix: update gapic-generator-java with mock service generation fixes (g…
be60779 
…oogleapis#475)

- [ ] Regenerate this pull request now.

PiperOrigin-RevId: 457524730

Source-Link: googleapis/googleapis@917e7f2

Source-Link: https://github.com/googleapis/googleapis-gen/commit/2497f9a069d3f6b2d6810d5a4e239cda1e7e5a39
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjQ5N2Y5YTA2OWQzZjZiMmQ2ODEwZDVhNGUyMzljZGExZTdlNWEzOSJ9
github-actions bot pushed a commit to suztomo/google-cloud-java that referenced this issue Jul 1, 2022
@release-please
chore(main): release 2.3.0 (googleapis#479)
f71ecd1 
🤖 I have created a release *beep* *boop*
---


## [2.3.0](googleapis/java-retail@v2.2.4...v2.3.0) (2022-07-01)


### Features

* Enable REST transport for most of Java and Go clients ([googleapis#471](googleapis/java-retail#471)) ([11c00f7](googleapis/java-retail@11c00f7))


### Bug Fixes

* update gapic-generator-java with mock service generation fixes ([googleapis#475](googleapis/java-retail#475)) ([be60779](googleapis/java-retail@be60779))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Jul 14, 2022
@release-please
chore(main): release 2.3.2-SNAPSHOT (#475)
a6f9829 
🤖 I have created a release *beep* *boop*
---


### Updating meta-information for bleeding-edge SNAPSHOT release.

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Sep 19, 2022
@release-please
chore(main): release 2.2.0 (#475)
4639304 
🤖 I have created a release *beep* *boop*
---


## [2.2.0](googleapis/java-assured-workloads@v2.1.0...v2.2.0) (2022-09-15)


### Features

* Add compliant_but_disallowed_services field to the v1beta1 Workload proto ([#476](googleapis/java-assured-workloads#476)) ([cbcb55d](googleapis/java-assured-workloads@cbcb55d))
* Updated v1beta1 analyzeWorkloadMove documentation ([#473](googleapis/java-assured-workloads#473)) ([903257b](googleapis/java-assured-workloads@903257b))


### Dependencies

* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.2 ([#478](googleapis/java-assured-workloads#478)) ([c646513](googleapis/java-assured-workloads@c646513))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.3 ([#480](googleapis/java-assured-workloads#480)) ([a48cd73](googleapis/java-assured-workloads@a48cd73))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Sep 30, 2022
@release-please
chore(main): release 0.13.3 (#482)
301483d 
🤖 I have created a release *beep* *boop*
---


## [0.13.3](googleapis/java-analytics-admin@v0.13.2...v0.13.3) (2022-09-29)


### Dependencies

* Update dependency cachetools to v5 ([#478](googleapis/java-analytics-admin#478)) ([1231930](googleapis/java-analytics-admin@1231930))
* Update dependency certifi to v2022.9.24 ([#460](googleapis/java-analytics-admin#460)) ([ec8852d](googleapis/java-analytics-admin@ec8852d))
* Update dependency charset-normalizer to v2.1.1 ([#464](googleapis/java-analytics-admin#464)) ([7aded8b](googleapis/java-analytics-admin@7aded8b))
* Update dependency click to v8.1.3 ([#465](googleapis/java-analytics-admin#465)) ([2ad11fb](googleapis/java-analytics-admin@2ad11fb))
* Update dependency gcp-releasetool to v1.8.8 ([#461](googleapis/java-analytics-admin#461)) ([52bcec4](googleapis/java-analytics-admin@52bcec4))
* Update dependency google-api-core to v2.10.1 ([#466](googleapis/java-analytics-admin#466)) ([f5f28e4](googleapis/java-analytics-admin@f5f28e4))
* Update dependency google-auth to v2.12.0 ([#467](googleapis/java-analytics-admin#467)) ([b96c8a3](googleapis/java-analytics-admin@b96c8a3))
* Update dependency google-cloud-core to v2.3.2 ([#462](googleapis/java-analytics-admin#462)) ([b444b65](googleapis/java-analytics-admin@b444b65))
* Update dependency google-cloud-storage to v2.5.0 ([#468](googleapis/java-analytics-admin#468)) ([620097f](googleapis/java-analytics-admin@620097f))
* Update dependency google-crc32c to v1.5.0 ([#469](googleapis/java-analytics-admin#469)) ([3f39cda](googleapis/java-analytics-admin@3f39cda))
* Update dependency googleapis-common-protos to v1.56.4 ([#463](googleapis/java-analytics-admin#463)) ([0fbc166](googleapis/java-analytics-admin@0fbc166))
* Update dependency importlib-metadata to v4.12.0 ([#470](googleapis/java-analytics-admin#470)) ([cc0108c](googleapis/java-analytics-admin@cc0108c))
* Update dependency jeepney to v0.8.0 ([#471](googleapis/java-analytics-admin#471)) ([1d09acc](googleapis/java-analytics-admin@1d09acc))
* Update dependency jinja2 to v3.1.2 ([#472](googleapis/java-analytics-admin#472)) ([9949a07](googleapis/java-analytics-admin@9949a07))
* Update dependency keyring to v23.9.3 ([#473](googleapis/java-analytics-admin#473)) ([443e7df](googleapis/java-analytics-admin@443e7df))
* Update dependency markupsafe to v2.1.1 ([#480](googleapis/java-analytics-admin#480)) ([ddebd04](googleapis/java-analytics-admin@ddebd04))
* Update dependency protobuf to v3.20.2 ([#481](googleapis/java-analytics-admin#481)) ([f0f032f](googleapis/java-analytics-admin@f0f032f))
* Update dependency protobuf to v4 ([#479](googleapis/java-analytics-admin#479)) ([754bb78](googleapis/java-analytics-admin@754bb78))
* Update dependency pyjwt to v2.5.0 ([#474](googleapis/java-analytics-admin#474)) ([6777481](googleapis/java-analytics-admin@6777481))
* Update dependency requests to v2.28.1 ([#475](googleapis/java-analytics-admin#475)) ([48dc786](googleapis/java-analytics-admin@48dc786))
* Update dependency typing-extensions to v4.3.0 ([#476](googleapis/java-analytics-admin#476)) ([8835380](googleapis/java-analytics-admin@8835380))
* Update dependency zipp to v3.8.1 ([#477](googleapis/java-analytics-admin#477)) ([3f004ad](googleapis/java-analytics-admin@3f004ad))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit that referenced this issue Oct 5, 2022
@release-please
chore(main): release 2.5.4 (#479)
b53c03b 
🤖 I have created a release *beep* *boop*
---


## [2.5.4](https://github.com/googleapis/java-security-private-ca/compare/v2.5.3...v2.5.4) (2022-10-03)


### Dependencies

* Update dependency certifi to v2022.9.24 ([#472](https://github.com/googleapis/java-security-private-ca/issues/472)) ([b7ac63c](https://github.com/googleapis/java-security-private-ca/commit/b7ac63c35497d3073146a3f917e9d71dfca6c7d5))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#481](https://github.com/googleapis/java-security-private-ca/issues/481)) ([0864f46](https://github.com/googleapis/java-security-private-ca/commit/0864f46174c3888ec1f28cbe6f0951abd069e68b))
* Update dependency google-api-core to v2.10.1 ([#469](https://github.com/googleapis/java-security-private-ca/issues/469)) ([e3a4332](https://github.com/googleapis/java-security-private-ca/commit/e3a4332bb76f06b6850dcb4ca0d6639284ff6129))
* Update dependency google-crc32c to v1.5.0 ([#470](https://github.com/googleapis/java-security-private-ca/issues/470)) ([f500bd9](https://github.com/googleapis/java-security-private-ca/commit/f500bd94f2237362038879f8b104ff79388270e4))
* Update dependency googleapis-common-protos to v1.56.4 ([#468](https://github.com/googleapis/java-security-private-ca/issues/468)) ([7a5b57b](https://github.com/googleapis/java-security-private-ca/commit/7a5b57b4730ffd93776118c9560e3b4a0f0733c0))
* Update dependency importlib-metadata to v4.12.0 ([#474](https://github.com/googleapis/java-security-private-ca/issues/474)) ([eb84232](https://github.com/googleapis/java-security-private-ca/commit/eb84232607ea80eb82bf8fd2b6da63f8594ceb33))
* Update dependency jeepney to v0.8.0 ([#471](https://github.com/googleapis/java-security-private-ca/issues/471)) ([f6da44a](https://github.com/googleapis/java-security-private-ca/commit/f6da44a8bde26f69274d0ef2e6984267e5e1476b))
* Update dependency jinja2 to v3.1.2 ([#475](https://github.com/googleapis/java-security-private-ca/issues/475)) ([7b39657](https://github.com/googleapis/java-security-private-ca/commit/7b396570d9e67206d206680180fdc32772193bc3))
* Update dependency keyring to v23.9.3 ([#476](https://github.com/googleapis/java-security-private-ca/issues/476)) ([03463c4](https://github.com/googleapis/java-security-private-ca/commit/03463c4b913fe798af911046b2128c4f8ee48327))
* Update dependency markupsafe to v2.1.1 ([#477](https://github.com/googleapis/java-security-private-ca/issues/477)) ([be28076](https://github.com/googleapis/java-security-private-ca/commit/be280768d46917a9922ae37565fb9f603c910783))
* Update dependency protobuf to v3.20.2 ([#478](https://github.com/googleapis/java-security-private-ca/issues/478)) ([4a3c940](https://github.com/googleapis/java-security-private-ca/commit/4a3c9400301db2a0af4a0375872a17b6fcacbefb))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo pushed a commit that referenced this issue Feb 1, 2023
@renovate-bot
deps: update dependency com.google.cloud:google-iam-policy to v1.6.4 (#…
2edd1e0 
…475)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-iam-policy](https://github.com/googleapis/java-eventarc) ([source](https://github.com/googleapis/java-iam)) | `1.6.3` -> `1.6.4` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.4/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.4/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.4/compatibility-slim/1.6.3)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-iam-policy/1.6.4/confidence-slim/1.6.3)](https://docs.renovatebot.com/merge-confidence/) |

---

### Release Notes

<details>
<summary>googleapis/java-iam</summary>

### [`v1.6.4`](https://github.com/googleapis/java-iam/blob/HEAD/CHANGELOG.md#&#8203;164-httpsgithubcomgoogleapisjava-iamcomparev163v164-2022-10-10)

[Compare Source](https://github.com/googleapis/java-iam/compare/v1.6.3...v1.6.4)

##### Dependencies

-   Update dependency com.google.cloud:google-iam-policy to v1.6.3 ([#&#8203;472](https://github.com/googleapis/java-iam/issues/472)) ([9a515d3](https://github.com/googleapis/java-iam/commit/9a515d317918b200810e43244df7c46dc17e221c))

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-iam).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMzAuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIzMC4wIn0=-->
suztomo pushed a commit that referenced this issue Feb 1, 2023
@release-please
chore(main): release 1.6.5 (#480)
465b096 
🤖 I have created a release *beep* *boop*
---


## [1.6.5](https://github.com/googleapis/java-iam/compare/v1.6.4...v1.6.5) (2022-10-24)


### Dependencies

* Update dependency com.google.apis:google-api-services-cloudresourcemanager to v3-rev20221016-2.0.0 ([#479](https://github.com/googleapis/java-iam/issues/479)) ([9f166f5](https://github.com/googleapis/java-iam/commit/9f166f52b9b35d5a1f7f6d108df4ad5a83d443b4))
* Update dependency com.google.auth:google-auth-library-oauth2-http to v1.12.1 ([#478](https://github.com/googleapis/java-iam/issues/478)) ([99688b0](https://github.com/googleapis/java-iam/commit/99688b038b014338a52119ba3f3217e9eed2228a))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.5 ([#486](https://github.com/googleapis/java-iam/issues/486)) ([0834a80](https://github.com/googleapis/java-iam/commit/0834a80fa202b4185177a1339ed103e0829dd759))
* Update dependency com.google.cloud:google-iam-policy to v1.6.4 ([#475](https://github.com/googleapis/java-iam/issues/475)) ([2edd1e0](https://github.com/googleapis/java-iam/commit/2edd1e077feb172830b2475efef0632f01154e9e))
* Update dependency com.google.protobuf:protobuf-bom to v3.21.8 ([#481](https://github.com/googleapis/java-iam/issues/481)) ([d9bab83](https://github.com/googleapis/java-iam/commit/d9bab83b9ec53c88aea55f7cebd7017e6cd8ca77))
* Update dependency com.google.protobuf:protobuf-java to v3.21.8 ([#482](https://github.com/googleapis/java-iam/issues/482)) ([fd38f00](https://github.com/googleapis/java-iam/commit/fd38f001b7b695e08b1882581abc7f08b0ebd4b6))
* Update dependency io.grpc:grpc-protobuf to v1.50.0 ([#476](https://github.com/googleapis/java-iam/issues/476)) ([8108ea5](https://github.com/googleapis/java-iam/commit/8108ea56a7977869ff088a6832a629b226b8f934))
* Update dependency io.grpc:grpc-protobuf to v1.50.2 ([#483](https://github.com/googleapis/java-iam/issues/483)) ([6d9adae](https://github.com/googleapis/java-iam/commit/6d9adaea40595dac65e867a654fc0cea502af41c))
* Update dependency io.grpc:grpc-stub to v1.50.2 ([#477](https://github.com/googleapis/java-iam/issues/477)) ([424f559](https://github.com/googleapis/java-iam/commit/424f559193d1130fc04db0f4bc49337c4f9f8d00))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jabubake jabubake

Labels
api: core api: logging Issues related to the Cloud Logging API. 🚨 This issue needs some love. triage me I really want to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@lesv @pongad @danoscarmike @aozarov @garrettjonesgoogle @michaelbausor @jabubake @yoshi-automation