Support setting library header in grpc services #1078
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add libraryName() and libraryVersion() to ServiceOptions - use setClientLibHeader in DefaultPubSubRpc
googlebot
added
the
cla: yes
|
/cc @aozarov |
| @@ -439,6 +441,20 @@ public String applicationName() { | |||
| return APPLICATION_NAME; | |||
| } | |||
|
|
|||
| /** | |||
| * Returns {@code gcloud-java}, the library's name, as a string. | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
Looks good. 2 minor comments. |
|
Looks good! |
mziccard
added a commit
to mziccard/gcloud-java
that referenced
this pull request
Jun 27, 2016
- add libraryName() and libraryVersion() to ServiceOptions - use setClientLibHeader in DefaultPubSubRpc
github-actions bot
pushed a commit
that referenced
this pull request
Oct 5, 2022
🤖 I have created a release *beep* *boop* --- ## [2.3.5](https://github.com/googleapis/java-translate/compare/v2.3.4...v2.3.5) (2022-10-03) ### Dependencies * Update dependency com.google.cloud:google-cloud-core to v2.8.12 ([#1076](https://github.com/googleapis/java-translate/issues/1076)) ([d76889c](https://github.com/googleapis/java-translate/commit/d76889cc92fb1cad71d4be4552d68c962deddfed)) * Update dependency com.google.cloud:google-cloud-core to v2.8.13 ([#1083](https://github.com/googleapis/java-translate/issues/1083)) ([3819209](https://github.com/googleapis/java-translate/commit/3819209e110df183aba335e22b404c6bc415772a)) * Update dependency com.google.cloud:google-cloud-core to v2.8.14 ([#1084](https://github.com/googleapis/java-translate/issues/1084)) ([c2e0417](https://github.com/googleapis/java-translate/commit/c2e04178b37396435f6c24d180fd67cbf9bfba3c)) * Update dependency com.google.cloud:google-cloud-core to v2.8.15 ([#1085](https://github.com/googleapis/java-translate/issues/1085)) ([554b02f](https://github.com/googleapis/java-translate/commit/554b02fa2b97ff4841ae35e7e43ab6c72335a97e)) * Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#1087](https://github.com/googleapis/java-translate/issues/1087)) ([dc3663e](https://github.com/googleapis/java-translate/commit/dc3663e29574467bd25400c7d91bd0c1ca036038)) * Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1090](https://github.com/googleapis/java-translate/issues/1090)) ([982faf0](https://github.com/googleapis/java-translate/commit/982faf0eba19064a3b82ad45c2567e613aa225e9)) * Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1092](https://github.com/googleapis/java-translate/issues/1092)) ([34fd42e](https://github.com/googleapis/java-translate/commit/34fd42e19a494aebfd1f6ab73274ed5b38f175a4)) * Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#1078](https://github.com/googleapis/java-translate/issues/1078)) ([06861c1](https://github.com/googleapis/java-translate/commit/06861c153ec52be12b8d2e891482bdef76f0a850)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
suztomo
pushed a commit
that referenced
this pull request
Feb 1, 2023
…1078) * chore: Upgrade to later version of gcp-uploader and protobuf * chore: Add secretstorage version * chore: Use python 3.9.13 * chore: Unpin all python versions * chore: Rerun pipcompile tool * chore: Rerun pipcompile tool with --allow-unsafe * chore: Add --require-hashes * chore: Update requirements file * chore: Remove --require-hashes * chore: Print python version * chore: Add new generated hashes for requirements.txt * chore: Remove python version check in cloud build * chore: Allow synthtool to update python dependencies * chore: Add typing-extensions into requirements * chore: Unpin docker requirements.in file * chore: Add java synthtool validation * chore: Add check to import java synthtool python package Source-Link: googleapis/synthtool@91904bf Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-java:latest@sha256:4566cf7fcd0eece77705330267b2b61a70165711c7829d049b60bc2f1bbcd74e Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does the following:
libraryName()andlibraryVersion()toServiceOptionssetClientLibHeaderinDefaultPubSubRpc