Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Google Cloud Pub/Sub #1085

Merged
merged 70 commits into from
Jun 28, 2016
Merged

Add support for Google Cloud Pub/Sub #1085

merged 70 commits into from
Jun 28, 2016

Conversation

mziccard
Copy link
Contributor

This PR takes all commits from the pubsub-alpha branch and rebases them on top of master.

No news here, all commits but the last one have already been reviewed.

The last commit does some dependency cleanup.

garrettjonesgoogle and others added 30 commits June 27, 2016 11:57
@garrettjonesgoogle @mziccard
Initial GAX submission - generated classes only
a0fd43a
@garrettjonesgoogle @mziccard
Updating README.md to latest form
66e176c
@garrettjonesgoogle @mziccard
Updating version and installation module
23294dc
@garrettjonesgoogle @mziccard
Adding GAX classes
19da84d
@garrettjonesgoogle @mziccard
Adding implicit dependency, using constant instead of hardcoded string
a884d58
@garrettjonesgoogle @mziccard
Initial submission of generated pubsub protobuf classes
e184b32
@garrettjonesgoogle @mziccard
Adding all sections to readme, with TODOs for missing content
980ba88
@garrettjonesgoogle @mziccard
Generated Pub/Sub client classes and unit tests
fce95f9
@garrettjonesgoogle @mziccard
Fixing source paths and module configuration
edd73cc
@garrettjonesgoogle @mziccard
Updates to address PR comments.
e26198e 
* license change
* update to notes on code updating
* renaming helper functions for creating fully-qualified paths
* making certain static final members private
* adding some documentation
* minor reformating
* Creating LocalPubsubHelper, using it in PublisherApiTest
* Making the constructor of PublisherApi protected so that subclasses can be created
@garrettjonesgoogle @mziccard
More updates to address PR comments
c291344 
* Making template constants private
* Adding helper methods to extract variables from template paths
* Making it possible to have multiple instances of LocalPubsubHelper
* Removing getChannel from *Api classes (not used anywhere)
* Other cleanup
@garrettjonesgoogle @mziccard
Third round of updates to address PR comments
6cc6456 
* ApiUtils: Fixing usage of credentials when channel is null
* ApiUtils: Function rename for clarity
* ApiUtils, ServiceApiSettings: improving comments
* ApiCallable: Removing obsolete stuff
* not returning 'this' from LocalPubsubHelper.start()
@pongad @mziccard
Delete duplicate LocalPublisherImpl.java
48b49b7
@aozarov @mziccard
merge from master
34f170c
@aozarov @mziccard
disable javadoc generation for java 8 on gcloud-java-pubsub
1671c0e
@garrettjonesgoogle @mziccard
Removing GAX from gcloud-java
a6be66f
@garrettjonesgoogle @mziccard
Removing generated files from gcloud-java-pubsub
78179b4
@garrettjonesgoogle @mziccard
Switching dependencies, regenerating code
44dd3d2 
* Add dependency on gax-java
* Add dependency on grpc-pubsub-v1
* Regenerating the *Api classes
* Using the emulator runner from GAX
* Updating the test accordingly
@garrettjonesgoogle @mziccard
Using version of GAX compatible with Java 1.7
c160a25
@garrettjonesgoogle @mziccard
Fixing doc problems, improving formatting
c286b88 
fixes googleapis#387 - Moving references of delete topics to get/list calls
fixes googleapis#386 - Removing the problematic wording
fixes googleapis#385 - Changing 'returns' to 'generates' when referencing errors
@garrettjonesgoogle @mziccard
Fixing javadoc error
39b713a
@garrettjonesgoogle @mziccard
Regenerating code, new settings classes
4ab3977 
* Moving settings constants and data into new settings classes
* Making use of ApiCallableBuilder in the new settings classes
* Simplifying the Api classes
@garrettjonesgoogle @mziccard
Updating to GAX 0.0.3
20c9bd3
@garrettjonesgoogle @mziccard
Surface updates from internal review
f253c54
@garrettjonesgoogle @mziccard
Using resurrected ServiceApiSettings in Settings classes
0b7b39a
@garrettjonesgoogle @mziccard
Updates due to code gen
7282c7a
@garrettjonesgoogle @mziccard
Removing newSettings() method from XApi classes
e2b1969
@garrettjonesgoogle @mziccard
Fixing build from last change
878ae88
@garrettjonesgoogle @mziccard
Putting spi files under spi.v1
7252fca
@garrettjonesgoogle @mziccard
Bundling descriptor for Publish
bece1d4
@mziccard
Fix deleted topic name: _deleted_topic_ -> _deleted-topic_ (googleapi…
ce2ace0 
…s#1023)
@mziccard
Add javadoc and tests for functional Topic class (googleapis#1021)
07a45e4
@mziccard
Implement ack and nack methods, add javadoc and tests (googleapis#1027)
47046e6
@mziccard
Add javadoc and tests for functional ReceivedMessage class (googleapi…
174849f 
…s#1038)
@mziccard
Add AckDeadlineRenewer class for automatic ack deadline renewal (goog…
f4e4e26 
…leapis#1031)

* Add AckDeadlineRenewer class for automatic ack deadline renewal

* Refactor renewer tests and wake up renewer only when needed

* Skip removed/re-added messages when scheduling new renewal

* Better tuning of ack deadline in renewer
@mziccard
Implement Iterator pull methods, add javadoc and tests (googleapis#1041)
54e179c
@mziccard
Fix PubSub Iterator pullAsync: add callback to PubSubRpc.pull (google…
337a8ef 
…apis#1048)
@mziccard
Add MessageConsumerImpl class, implement pullAsync, add tests (google…
f6f552e 
…apis#1043)
@mziccard
Add serialization test for PubSub classes (googleapis#1072)
d7ac46d
@mziccard
Add javadoc and tests for Subscription (googleapis#1074)
933c985
@mziccard
Add docs to PubSub spi layer (googleapis#1066)
fec0e12
@mziccard
Add PubSub examples, update READMEs and package-info javadoc (googlea…
57883ae 
…pis#1075)
@mziccard
Support setting library header in grpc services (googleapis#1078)
2553b89 
- add libraryName() and libraryVersion() to ServiceOptions
- use setClientLibHeader in DefaultPubSubRpc
@mziccard
Add integration tests to pubsub (googleapis#1080)
098ab65
@mziccard
Update grpc-related dependencies, remove gax dependency from pubsub
fb3e663
@mziccard mziccard added the api: pubsub Issues related to the Pub/Sub API. label Jun 27, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 27, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 86.153% when pulling fb3e663 on mziccard:add-pubsub-support into 20e5280 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

@lesv do you mind having a look at the latest commit? (previous commits have already been reviewed)

@lesv
Copy link
Contributor

lesv commented Jun 28, 2016

LGTM - on the last commit.

@coveralls
Copy link

coveralls commented Jun 28, 2016 •
edited
Loading

Coverage Status

Coverage increased (+0.06%) to 86.153% when pulling aefce68 on mziccard:add-pubsub-support into 20e5280 on GoogleCloudPlatform:master.

@mziccard
Copy link
Contributor Author

mziccard commented Jun 28, 2016 •
edited
Loading

@lesv thanks for the pass, I just added one more commit (aefce68) to fix a broking link in the main README. You can see it fixed here.

@mziccard mziccard merged commit f5b5d3d into googleapis:master Jun 28, 2016
@lesv
Copy link
Contributor

lesv commented Jun 29, 2016

LGTM

This was referenced Jul 22, 2016
Closed
Closed
github-actions bot pushed a commit that referenced this pull request Oct 5, 2022
@release-please
chore(main): release 2.3.5 (#1082)
527362c 
🤖 I have created a release *beep* *boop*
---


## [2.3.5](https://github.com/googleapis/java-translate/compare/v2.3.4...v2.3.5) (2022-10-03)


### Dependencies

* Update dependency com.google.cloud:google-cloud-core to v2.8.12 ([#1076](https://github.com/googleapis/java-translate/issues/1076)) ([d76889c](https://github.com/googleapis/java-translate/commit/d76889cc92fb1cad71d4be4552d68c962deddfed))
* Update dependency com.google.cloud:google-cloud-core to v2.8.13 ([#1083](https://github.com/googleapis/java-translate/issues/1083)) ([3819209](https://github.com/googleapis/java-translate/commit/3819209e110df183aba335e22b404c6bc415772a))
* Update dependency com.google.cloud:google-cloud-core to v2.8.14 ([#1084](https://github.com/googleapis/java-translate/issues/1084)) ([c2e0417](https://github.com/googleapis/java-translate/commit/c2e04178b37396435f6c24d180fd67cbf9bfba3c))
* Update dependency com.google.cloud:google-cloud-core to v2.8.15 ([#1085](https://github.com/googleapis/java-translate/issues/1085)) ([554b02f](https://github.com/googleapis/java-translate/commit/554b02fa2b97ff4841ae35e7e43ab6c72335a97e))
* Update dependency com.google.cloud:google-cloud-core to v2.8.18 ([#1087](https://github.com/googleapis/java-translate/issues/1087)) ([dc3663e](https://github.com/googleapis/java-translate/commit/dc3663e29574467bd25400c7d91bd0c1ca036038))
* Update dependency com.google.cloud:google-cloud-core to v2.8.19 ([#1090](https://github.com/googleapis/java-translate/issues/1090)) ([982faf0](https://github.com/googleapis/java-translate/commit/982faf0eba19064a3b82ad45c2567e613aa225e9))
* Update dependency com.google.cloud:google-cloud-shared-dependencies to v3.0.4 ([#1092](https://github.com/googleapis/java-translate/issues/1092)) ([34fd42e](https://github.com/googleapis/java-translate/commit/34fd42e19a494aebfd1f6ab73274ed5b38f175a4))
* Update dependency com.google.cloud:google-cloud-storage to v2.12.0 ([#1078](https://github.com/googleapis/java-translate/issues/1078)) ([06861c1](https://github.com/googleapis/java-translate/commit/06861c153ec52be12b8d2e891482bdef76f0a850))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actions bot pushed a commit to yoshi-code-bot/google-cloud-java that referenced this pull request Oct 6, 2022
@renovate-bot
chore(deps): update dependency com.google.cloud:google-cloud-aiplatfo…
52075e8 
…rm to v3.4.0 (googleapis#1085)

[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [com.google.cloud:google-cloud-aiplatform](https://github.com/googleapis/java-aiplatform) ([source](https://github.com/googleapis/java-)) | `3.3.0` -> `3.4.0` | [![age](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/3.4.0/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/3.4.0/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/3.4.0/compatibility-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/maven/com.google.cloud:google-cloud-aiplatform/3.4.0/confidence-slim/3.3.0)](https://docs.renovatebot.com/merge-confidence/) |

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Renovate will not automatically rebase this PR, because other commits have been found.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. ⚠ **Warning**: custom changes will be lost.

---

This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/googleapis/java-aiplatform).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMTQuMCIsInVwZGF0ZWRJblZlciI6IjMyLjIxNC4wIn0=-->
suztomo pushed a commit that referenced this pull request Feb 1, 2023
@release-please
chore(main): release 2.9.3 (#1085)
cc9a8cd 
🤖 I have created a release *beep* *boop*
---


## [2.9.3](https://github.com/googleapis/java-core/compare/v2.9.2...v2.9.3) (2023-01-19)


### Dependencies

* Update dependency com.google.api:api-common to v2.5.0 ([#1083](https://github.com/googleapis/java-core/issues/1083)) ([2f648e6](https://github.com/googleapis/java-core/commit/2f648e627985019558999dc6ddec37346903d55a))
* Update dependency com.google.api:gax-bom to v2.22.0 ([#1084](https://github.com/googleapis/java-core/issues/1084)) ([18d093e](https://github.com/googleapis/java-core/commit/18d093ec9d6b85e59b00dd050690d0516dd60af1))
* Update dependency com.google.api.grpc:proto-google-common-protos to v2.13.0 ([#1081](https://github.com/googleapis/java-core/issues/1081)) ([5192e63](https://github.com/googleapis/java-core/commit/5192e63299c4fda09dcab0a330dcc8a56f31947c))
* Update dependency com.google.api.grpc:proto-google-iam-v1 to v1.8.0 ([#1082](https://github.com/googleapis/java-core/issues/1082)) ([2c2bc97](https://github.com/googleapis/java-core/commit/2c2bc97e25a82582b3180cd0fd07ea25c5e0eb05))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mziccard @coveralls @lesv @googlebot @garrettjonesgoogle @pongad @aozarov @shinfan @michaelbausor