Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Remove anthos-dpe from owners #8271

Merged
merged 1 commit into from
Sep 7, 2022
Merged

chore: Remove anthos-dpe from owners #8271

merged 1 commit into from
Sep 7, 2022

Conversation

bourgeoisor
Copy link
Contributor

@bourgeoisor bourgeoisor commented Sep 1, 2022 •
edited
Loading

@bourgeoisor bourgeoisor requested review from donmccasland and a team September 1, 2022 17:55
This was referenced Sep 1, 2022
Merged
Merged
Merged
Merged
@bourgeoisor bourgeoisor changed the title Remove anthos-dpe from owners chore: Remove anthos-dpe from owners Sep 1, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@bourgeoisor bourgeoisor force-pushed the issue-remove-anthos-dpe-owners branch from 39026a7 to 1a06768 Compare September 1, 2022 18:07
@bourgeoisor bourgeoisor added kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 1, 2022
@bourgeoisor bourgeoisor requested a review from suztomo September 6, 2022 15:53
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 6, 2022
@suztomo
Copy link
Member

suztomo commented Sep 7, 2022 •
edited
Loading

I don't think #8271 is necessary, as CODEOWNERS file in java-container is not recognized by GitHub. It's just copied from java-container:

To use a CODEOWNERS file, create a new file called CODEOWNERS in the root, docs/, or .github/ directory of the repository

https://docs.github.com/en/repositories/managing-your-repositorys-settings-and-features/customizing-your-repository/about-code-owners

(But no harm to merging this PR, just to be consistent with googleapis/java-container#779

@suztomo suztomo closed this Sep 7, 2022
@suztomo suztomo reopened this Sep 7, 2022
@suztomo suztomo added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Sep 7, 2022
meltsufin
meltsufin approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@meltsufin meltsufin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that @googleapis/java-samples-reviewers doesn't exist.

@suztomo
Copy link
Member

suztomo commented Sep 7, 2022

The team exists but not having Write access to this repository.

@suztomo suztomo merged commit d872e63 into main Sep 7, 2022
@suztomo suztomo deleted the issue-remove-anthos-dpe-owners branch September 7, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meltsufin meltsufin meltsufin approved these changes

@donmccasland donmccasland donmccasland approved these changes

@suztomo suztomo Awaiting requested review from suztomo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bourgeoisor @suztomo @donmccasland @meltsufin @yoshi-kokoro