-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, LGTM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, hold on this might be an autogenerated file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comment below to properly format CODEOWNERS file for this repo.
.github/CODEOWNERS
Outdated
# @googleapis/yoshi-python @googleapis/anthos-dpe are the default owners for changes in this repo | ||
* @googleapis/yoshi-python @googleapis/anthos-dpe | ||
# @googleapis/yoshi-python @googleapis/yoshi-python are the default owners for changes in this repo | ||
* @googleapis/yoshi-python @googleapis/yoshi-python |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why twice?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's due to the file being templated. The suggestion I put should help get things fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ohhh I see. That's OwlBot doing its thing, I think I know what's going on--
Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OwlBot behaved! 🦉 LGTM.
This PR removes
anthos-dpe
from the owners of this repository, as it's been fully handed over to the corresponding Yoshi team.Related PRs: