Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

chore: Remove anthos-dpe from owners #285

Merged
merged 5 commits into from
Sep 1, 2022
Merged

Conversation

bourgeoisor
Copy link
Contributor

@bourgeoisor bourgeoisor commented Sep 1, 2022

@bourgeoisor bourgeoisor requested review from a team as code owners September 1, 2022 17:55
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: container Issues related to the googleapis/python-container API. labels Sep 1, 2022
@bourgeoisor bourgeoisor changed the title Remove anthos-dpe from owners chore: Remove anthos-dpe from owners Sep 1, 2022
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nit, LGTM.

.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, hold on this might be an autogenerated file.

Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment below to properly format CODEOWNERS file for this repo.

.repo-metadata.json Outdated Show resolved Hide resolved
# @googleapis/yoshi-python @googleapis/anthos-dpe are the default owners for changes in this repo
* @googleapis/yoshi-python @googleapis/anthos-dpe
# @googleapis/yoshi-python @googleapis/yoshi-python are the default owners for changes in this repo
* @googleapis/yoshi-python @googleapis/yoshi-python
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why twice?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's due to the file being templated. The suggestion I put should help get things fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ohhh I see. That's OwlBot doing its thing, I think I know what's going on--

Co-authored-by: Dan Lee <71398022+dandhlee@users.noreply.github.com>
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: s Pull request size is small. labels Sep 1, 2022
@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 1, 2022
Copy link
Contributor

@dandhlee dandhlee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OwlBot behaved! 🦉 LGTM.

@dandhlee dandhlee merged commit 1bcc63c into main Sep 1, 2022
@dandhlee dandhlee deleted the issue-remove-anthos-dpe-owners branch September 1, 2022 22:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
api: container Issues related to the googleapis/python-container API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants