Skip to content

Commit

Permalink
Clarify 'response_type' for signed_url methods. (#8942)
Browse files Browse the repository at this point in the history
Fixes: #7696.
  • Loading branch information
HemangChothani authored and tseaver committed Aug 7, 2019
1 parent dd4c5a1 commit 3d29c75
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions storage/google/cloud/storage/_signing.py
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,8 @@ def generate_signed_url_v2(
:type response_type: str
:param response_type: (Optional) Content type of responses to requests for
the signed URL. Used to over-ride the content type of
the underlying resource.
the signed URL. Ignored if content_type is set on
object/blob metadata.
:type response_disposition: str
:param response_disposition: (Optional) Content disposition of responses to
Expand Down Expand Up @@ -467,8 +467,8 @@ def generate_signed_url_v4(
:type response_type: str
:param response_type: (Optional) Content type of responses to requests for
the signed URL. Used to over-ride the content type of
the underlying resource.
the signed URL. Ignored if content_type is set on
object/blob metadata.
:type response_disposition: str
:param response_disposition: (Optional) Content disposition of responses to
Expand Down
4 changes: 2 additions & 2 deletions storage/google/cloud/storage/blob.py
Original file line number Diff line number Diff line change
Expand Up @@ -365,8 +365,8 @@ def generate_signed_url(
:type response_type: str
:param response_type: (Optional) Content type of responses to requests
for the signed URL. Used to over-ride the content
type of the underlying blob/object.
for the signed URL. Ignored if content_type is
set on object/blob metadata.
:type generation: str
:param generation: (Optional) A value that indicates which generation
Expand Down

0 comments on commit 3d29c75

Please sign in to comment.