Storage: Fix documentation misleading response_type signed_url #8942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HemangChothani
requested review from
crwilcox,
frankyn and
tseaver
as code owners
googlebot
added
the
cla: yes
tseaver
suggested changes
Aug 6, 2019
| @@ -321,7 +321,7 @@ def generate_signed_url_v2( | |||
|
|
|||
| :type response_type: str | |||
| :param response_type: (Optional) Content type of responses to requests for | |||
| the signed URL. Ignored if content_type is set. | |||
| the signed URL. Ignored if content_type is set on object/blob metadata. | |||
There was a problem hiding this comment.
Please wrap to the next line here (and the other similar docstrings).
| @@ -475,7 +475,7 @@ def list_blobs( | |||
| versions=versions, | |||
| projection=projection, | |||
| fields=fields, | |||
| client=self | |||
| client=self, | |||
There was a problem hiding this comment.
Please rebase against the head of master, which already has this change (and the others below) from PR #8831.
MaxxleLLC
force-pushed
the
fix/documentation_misleading_responsetype_signedurl
branch
from
e0e059c
to
68db71a
Compare
tseaver
approved these changes
Aug 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #7696