Add coverage for can't-get-here 'else' clause.

Addresses: #1665 (comment)
googleapis · Mar 28, 2016 · 9a9a376 · 9a9a376
1 parent 145ec60
commit 9a9a376
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/gcloud/logging/logger.py b/gcloud/logging/logger.py
@@ -289,7 +289,7 @@ def commit(self, client=None):
                 as_json_str = MessageToJson(entry)
                 as_json = json.loads(as_json_str)
                 info = {'protoPayload': as_json}
-            else:  # pragma: NO COVER
+            else:
                 raise ValueError('Unknown entry type: %s' % (entry_type,))
             entries.append(info)
 

diff --git a/gcloud/logging/test_logger.py b/gcloud/logging/test_logger.py
@@ -318,6 +318,15 @@ def test_log_proto(self):
         self.assertEqual(len(connection._requested), 0)
         self.assertEqual(batch.entries, [('proto', message)])
 
+    def test_commit_w_invalid_entry_type(self):
+        logger = _Logger()
+        conn = _Connection()
+        CLIENT = _Client(project=self.PROJECT, connection=conn)
+        batch = self._makeOne(logger, CLIENT)
+        batch.entries.append(('bogus', 'BOGUS'))
+        with self.assertRaises(ValueError):
+            batch.commit()
+
     def test_commit_w_bound_client(self):
         import json
         from google.protobuf.json_format import MessageToJson