Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Looks like we don't expose the Dataset class as datastore.Dataset? #709

Closed
jgeewax opened this issue Mar 12, 2015 · 2 comments · Fixed by #715
Closed

Looks like we don't expose the Dataset class as datastore.Dataset? #709

jgeewax opened this issue Mar 12, 2015 · 2 comments · Fixed by #715
Assignees
@dhermes
Labels
api: datastore Issues related to the Datastore API.

Comments

@jgeewax
Copy link
Contributor

jgeewax commented Mar 12, 2015

There are some docs that use the following syntax:

>>> from gcloud import datastore
>>> dataset = datastore.get_dataset('dataset-id')

I'm not sure if this is accurate, but either way, if we're following the convention of datastore/init.py, this should be:

>>> from gcloud import datastore
>>> dataset = datastore.Dataset('dataset-id')

However I don't see the import in __init__.py, so I'm guessing that neither of these work...?
@jgeewax jgeewax added api: datastore Issues related to the Datastore API. docs labels Mar 12, 2015
@jgeewax jgeewax added this to the Datastore Stable milestone Mar 12, 2015
@dhermes dhermes self-assigned this Mar 12, 2015
@dhermes
Copy link
Contributor

dhermes commented Mar 12, 2015

Yeah get_dataset doesn't exist, I'm on it.

I did a git blame and that text was added in #509, a looooong time ago.

dhermes added a commit to dhermes/google-cloud-python that referenced this issue Mar 12, 2015
@dhermes
Fixing Batch class docstring (referenced dead code).
bbd049b 
Also adding Dataset class as a documented import in the
datastore package __init__.

Fixes googleapis#709.
@dhermes dhermes mentioned this issue Mar 12, 2015
Merged
@dhermes
Copy link
Contributor

dhermes commented Mar 12, 2015

@jgeewax It turns out that dead code wasn't being used in the snippet anyhow, so it just gets axed in #715

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dhermes dhermes

Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing Batch class docstring (referenced dead code). dhermes/google-cloud-python
2 participants
@jgeewax @dhermes