Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a 'Batch': collects non-transactional saves / deletes. #509

Merged
merged 2 commits into from
Jan 8, 2015
Merged

Add a 'Batch': collects non-transactional saves / deletes. #509

merged 2 commits into from
Jan 8, 2015

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Jan 8, 2015

Closes #421.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 90a20d1 on tseaver:421-dataset_batch_put_delete into * on GoogleCloudPlatform:master*.

@tseaver
Copy link
Contributor Author

tseaver commented Jan 8, 2015

Batch largely patterend after Transaction: we could maybe even derive Transation from batch.

Note that I dropped the "update auto_id keys" bits on the floor: we can add them if they are important for the usecase.

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling 65621f3 on tseaver:421-dataset_batch_put_delete into f577b30 on GoogleCloudPlatform:master.

dhermes
dhermes reviewed Jan 8, 2015
View reviewed changes
gcloud/datastore/batch.py
properties = dict(entity)
exclude = tuple(entity.exclude_from_indexes)

self.connection.save_entity(

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

It's pleasantly surprising how simple the tweaks to Connection were!

I have some other ideas floating around that relate to this (including #495). Could we jump on a video chat tomorrow (January 8) AM to discuss?

I was initially thrown off by the Batch concept since I am used to a strict distinction of ndb.put_multi and ndb.delete_multi. However, Mutation is happy to accommodate all.

@dhermes dhermes mentioned this pull request Jan 8, 2015
Merged
dhermes
dhermes reviewed Jan 8, 2015
View reviewed changes
gcloud/datastore/batch.py
raise ValueError('A batch must have a connection and '
'a dataset ID set.')

self._id = None

This comment was marked as spam.

Sign in to view

This comment was marked as spam.

Sign in to view

@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

LGTM save for removing self._id (a remnant of Transaction).

I'll write up a bug outlining a "migration" path based off #495

@tseaver
Copy link
Contributor Author

tseaver commented Jan 8, 2015

I have changes stashed which add the "insert_auto_id*" fixups to Batch. Should I push them, or defer to another PR?

@coveralls
Copy link

Coverage Status

Coverage remained the same when pulling cf6873b on tseaver:421-dataset_batch_put_delete into f577b30 on GoogleCloudPlatform:master.

@dhermes dhermes mentioned this pull request Jan 8, 2015
Closed
8 tasks
@dhermes
Copy link
Contributor

dhermes commented Jan 8, 2015

Let's defer to another PR so we can ask Patrick about it without lots of distracting other code.

tseaver added a commit that referenced this pull request Jan 8, 2015
@tseaver
Merge pull request #509 from tseaver/421-dataset_batch_put_delete
3a448f3 
Add a 'Batch': collects non-transactional saves / deletes.
@tseaver tseaver merged commit 3a448f3 into googleapis:master Jan 8, 2015
@tseaver tseaver deleted the 421-dataset_batch_put_delete branch January 8, 2015 18:17
@tseaver tseaver mentioned this pull request Jan 8, 2015
Merged
@dhermes dhermes mentioned this pull request Jan 10, 2015
Closed
@dhermes dhermes mentioned this pull request Mar 12, 2015
Closed
@dhermes dhermes added the api: datastore Issues related to the Datastore API. label Dec 31, 2015
atulep pushed a commit that referenced this pull request Apr 3, 2023
@gcf-owl-bot
docs: fix the resource name format in comment for CreatePhraseSetRequ…
7f02b8f 
…est (#509)

* feat: Add support for BatchRecognize

Deprecate the `update_config_request` field in the `OperationMetadata` message, which was never used and is output only.

PiperOrigin-RevId: 517976288

Source-Link: googleapis/googleapis@7ee7867

Source-Link: googleapis/googleapis-gen@04050e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDQwNTBlMTVlN2E0MDlmOWQ0MjFmNjNkYmZkZjM3ZWFjNzJhM2MxNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: fix the resource name format in comment for CreatePhraseSetRequest

PiperOrigin-RevId: 518025142

Source-Link: googleapis/googleapis@e354eef

Source-Link: googleapis/googleapis-gen@f3e2685
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjNlMjY4NTBlYjU0NWYzN2U0MWEzZGE3MTQyNmQxMzIwMmVhZTAxMyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
docs: fix the resource name format in comment for CreatePhraseSetRequ…
aaf6c95 
…est (#509)

* feat: Add support for BatchRecognize

Deprecate the `update_config_request` field in the `OperationMetadata` message, which was never used and is output only.

PiperOrigin-RevId: 517976288

Source-Link: googleapis/googleapis@7ee7867

Source-Link: googleapis/googleapis-gen@04050e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDQwNTBlMTVlN2E0MDlmOWQ0MjFmNjNkYmZkZjM3ZWFjNzJhM2MxNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: fix the resource name format in comment for CreatePhraseSetRequest

PiperOrigin-RevId: 518025142

Source-Link: googleapis/googleapis@e354eef

Source-Link: googleapis/googleapis-gen@f3e2685
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjNlMjY4NTBlYjU0NWYzN2U0MWEzZGE3MTQyNmQxMzIwMmVhZTAxMyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 6, 2023
@gcf-owl-bot
docs: fix the resource name format in comment for CreatePhraseSetRequ…
06d5337 
…est (#509)

* feat: Add support for BatchRecognize

Deprecate the `update_config_request` field in the `OperationMetadata` message, which was never used and is output only.

PiperOrigin-RevId: 517976288

Source-Link: googleapis/googleapis@7ee7867

Source-Link: googleapis/googleapis-gen@04050e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDQwNTBlMTVlN2E0MDlmOWQ0MjFmNjNkYmZkZjM3ZWFjNzJhM2MxNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: fix the resource name format in comment for CreatePhraseSetRequest

PiperOrigin-RevId: 518025142

Source-Link: googleapis/googleapis@e354eef

Source-Link: googleapis/googleapis-gen@f3e2685
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjNlMjY4NTBlYjU0NWYzN2U0MWEzZGE3MTQyNmQxMzIwMmVhZTAxMyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
atulep pushed a commit that referenced this pull request Apr 18, 2023
@gcf-owl-bot
docs: fix the resource name format in comment for CreatePhraseSetRequ…
dd4c472 
…est (#509)

* feat: Add support for BatchRecognize

Deprecate the `update_config_request` field in the `OperationMetadata` message, which was never used and is output only.

PiperOrigin-RevId: 517976288

Source-Link: googleapis/googleapis@7ee7867

Source-Link: googleapis/googleapis-gen@04050e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDQwNTBlMTVlN2E0MDlmOWQ0MjFmNjNkYmZkZjM3ZWFjNzJhM2MxNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: fix the resource name format in comment for CreatePhraseSetRequest

PiperOrigin-RevId: 518025142

Source-Link: googleapis/googleapis@e354eef

Source-Link: googleapis/googleapis-gen@f3e2685
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjNlMjY4NTBlYjU0NWYzN2U0MWEzZGE3MTQyNmQxMzIwMmVhZTAxMyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Aug 15, 2023
@renovate-bot
chore(deps): update dependency google-cloud-dialogflow-cx to v1.20.0 (#…
ee3187e 
…509)
vchudnov-g pushed a commit that referenced this pull request Sep 20, 2023
@gcf-owl-bot @parthea
fix: correct broken ConversationModelEvaluation resource pattern (#509)
f4ff416 
* fix!: correct broken ConversationModelEvaluation resource pattern

PiperOrigin-RevId: 442646533

Source-Link: googleapis/googleapis@b62c562

Source-Link: googleapis/googleapis-gen@f5c157c
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjVjMTU3YzY4MTE1ODQ3ZDc4ZWI4NDEyNzM0Y2I4MmU3ZDU1MTViNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: Anthonios Partheniou <partheniou@google.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@release-please
chore(main): release 5.1.0 (#509)
b098c28 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Sep 22, 2023
@gcf-owl-bot
chore: Update gapic-generator-python to v1.11.4 (#509)
764c4b2 
* chore: Update gapic-generator-python to v1.11.4

PiperOrigin-RevId: 547897126

Source-Link: googleapis/googleapis@c09c75e

Source-Link: googleapis/googleapis-gen@45e0ec4
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDVlMGVjNDM0MzUxN2NkMGFhNjZiNWNhNjQyMzJhMTgwMmMyZjk0NSJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@minherz
fix: add metric label example to the snippet (#509)
cd3a4f1 
add code line to set metric label in addition to resource label.
make the code sample align with similar samples in other languages.
parthea pushed a commit that referenced this pull request Oct 21, 2023
@release-please
chore(main): release 3.2.0 (#509)
3bf28d8 
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 21, 2023
@gcf-owl-bot
chore: [autoapprove] bump cryptography from 41.0.3 to 41.0.4 (#509)
cb9c654 
Source-Link: googleapis/synthtool@dede53f
Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:fac304457974bb530cc5396abd4ab25d26a469cd3bc97cbfb18c8d4324c584eb

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
parthea pushed a commit that referenced this pull request Oct 22, 2023
@gcf-owl-bot
docs: fix the resource name format in comment for CreatePhraseSetRequ…
8e6d6e3 
…est (#509)

* feat: Add support for BatchRecognize

Deprecate the `update_config_request` field in the `OperationMetadata` message, which was never used and is output only.

PiperOrigin-RevId: 517976288

Source-Link: googleapis/googleapis@7ee7867

Source-Link: googleapis/googleapis-gen@04050e1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDQwNTBlMTVlN2E0MDlmOWQ0MjFmNjNkYmZkZjM3ZWFjNzJhM2MxNCJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

* docs: fix the resource name format in comment for CreatePhraseSetRequest

PiperOrigin-RevId: 518025142

Source-Link: googleapis/googleapis@e354eef

Source-Link: googleapis/googleapis-gen@f3e2685
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjNlMjY4NTBlYjU0NWYzN2U0MWEzZGE3MTQyNmQxMzIwMmVhZTAxMyJ9

* 🦉 Updates from OwlBot post-processor

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

---------

Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: datastore Issues related to the Datastore API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Batch dataset.put and dataset.delete.
3 participants
@tseaver @coveralls @dhermes