Moving gRPC stub-with-auth helpers out of bigtable package. #2082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| access tokens. | ||
|
|
||
| :type user_agent: str | ||
| :param user_agent: (Optional) The user agent to be used with API requests. |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM modulo docstring comments. |
Also changing the metadata plugin to take credentials and user agent directly instead of inferring those values from a client (this is because the Bigtable client is unique in it's attributes).
dhermes
force-pushed
the
move-bigtable-stub-helper-into-general
branch
from
493a490
to
8bdf12c
Compare
googlebot
added
the
cla: yes
Merged
parthea
pushed a commit
that referenced
this pull request
Oct 21, 2023
)](GoogleCloudPlatform/python-docs-samples#2082) There's some latency between bucket creation and when it's reflected in the backend. Need to delay in order to make the API call successfully.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also changing the metadata plugin to take credentials and user agent directly instead of inferring those values from a client (this is because the Bigtable client is unique in it's attributes).
This is in preparation for gRPC support for datastore as is #2081