-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut 0.19.0 release. #2270
Cut 0.19.0 release. #2270
Conversation
@dhermes qq: did we resolve the namespace/import issue? Will users be able to do; from google.cloud import storage
storage_client = storage.Client() ? |
Other than the services in #2258 ( |
Can I be a jerk and block the release on that issue? I would prefer not to have to update sample code twice. |
@bjwatson Thoughts on timing? @jonparrott We are just in a state of flux until a release is cut. |
@dhermes also, do we have a changelog? |
I have yet to make the changelog. I'm a bit weary of doing it, it'll be big. Also some people may have started doing squash merges so my typical script won't see those PRs? |
@dhermes @jonparrott I would like to resolve the following first if possible:
I can be talked out of any of these if there are urgent overriding needs to get this release out. |
@bjwatson Do you have a timeframe on this? e.g. why hasn't the LGTM'd PR been merged? |
|
@bjwatson gax-python 0.13.0 has been published, although until we refresh codegen, the |
It'd be nice to have it in today, but I trust you're going as quick as you can. |
@dhermes I am. Regarding #2258, we can reduce risk and maybe get it done sooner by just focusing on the GAX namespace. The other part of the problem is fixing the gRPC namespace, mainly to be more consistent, but also to avoid conflicts for the ML libraries (the gRPC packages currently use |
That SGTM. |
This would be great to get a 0.19.0 onto https://cloud.google.com/datastore/release-notes
The previous 0.18.1 release had |
@overset Thanks for the heads up. FWIW, we haven't supported
Check out the release history for relevant releases near those dates |
Sure thing. Not sure when |
Time to make release notes. Yay for 130+ PRs!
yields #2035 |
This is the first release after the rename. Closes googleapis#2264.
I've tweaked the entries all into imperative mode. |
Thanks @tseaver |
I updated vision to be more verbose so it's easier to reference later if needed. |
Content moved to #2336. |
@tseaver @daspecster Are we good to merge here? (Don't know why Travis is being fast on "push" builds to master but not "pr" builds.) |
Green! |
LGTM |
Pushed the tag and added the notes: https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/0.19.0 (may need #2347 update) Push to PyPI should come from: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/161121136 |
I updated the release notes to include the changes from #2347. |
This is the first release after the rename.
Also updated the account that does deployment from Silvio's to one shared by google-cloud. We'll likely need to ditch the
deploy
section and write a more customized script usingtwine
once we deploy versions for each sub-package.Closes #2264.