Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut 0.19.0 release. #2270

Merged
merged 1 commit into from
Sep 19, 2016
Merged

Cut 0.19.0 release. #2270

merged 1 commit into from
Sep 19, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 8, 2016

This is the first release after the rename.

Also updated the account that does deployment from Silvio's to one shared by google-cloud. We'll likely need to ditch the deploy section and write a more customized script using twine once we deploy versions for each sub-package.

Closes #2264.

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 8, 2016
@theacodes
Copy link
Contributor

@dhermes qq: did we resolve the namespace/import issue? Will users be able to do;

from google.cloud import storage

storage_client = storage.Client()

?

@dhermes
Copy link
Contributor Author

dhermes commented Sep 8, 2016

Other than the services in #2258 (logging and pubsub) everything is a normal package (not a namespace package)

@theacodes
Copy link
Contributor

Can I be a jerk and block the release on that issue? I would prefer not to have to update sample code twice.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 8, 2016

@bjwatson Thoughts on timing?

@jonparrott We are just in a state of flux until a release is cut.

@theacodes
Copy link
Contributor

@dhermes how bad is the state of flux? is it better to push this out quickly or wait for #2258 to be resolved? Are they any other issues that would make upgrading more trivial than just updating imports?

(Apologies for the slew of questions, I just want to make sure I understand the full picture)

@theacodes
Copy link
Contributor

@dhermes also, do we have a changelog?

@dhermes
Copy link
Contributor Author

dhermes commented Sep 8, 2016

I have yet to make the changelog. I'm a bit weary of doing it, it'll be big. Also some people may have started doing squash merges so my typical script won't see those PRs?

@bjwatson
Copy link

bjwatson commented Sep 8, 2016

@dhermes @jonparrott I would like to resolve the following first if possible:

I can be talked out of any of these if there are urgent overriding needs to get this release out.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 9, 2016

@bjwatson Do you have a timeframe on this? e.g. why hasn't the LGTM'd PR been merged?

@bjwatson
Copy link

bjwatson commented Sep 9, 2016

@dhermes

@geigerj
Copy link
Contributor

geigerj commented Sep 9, 2016

@bjwatson gax-python 0.13.0 has been published, although until we refresh codegen, the gax-google-... packages will still be restricted to 0.12.x.

@bjwatson
Copy link

bjwatson commented Sep 9, 2016

We can refresh the packages as part of #2258, unless @dhermes needs this done sooner.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 9, 2016

It'd be nice to have it in today, but I trust you're going as quick as you can.

@bjwatson
Copy link

bjwatson commented Sep 9, 2016

@dhermes I am. Regarding #2258, we can reduce risk and maybe get it done sooner by just focusing on the GAX namespace.

The other part of the problem is fixing the gRPC namespace, mainly to be more consistent, but also to avoid conflicts for the ML libraries (the gRPC packages currently use google.cloud.{api} as a namespace for language, vision, and speech). We can hand-fix the ML gRPC packages ASAP, and then fix the other gRPC packages a little later.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 9, 2016

That SGTM.

@overset
Copy link

overset commented Sep 15, 2016

This would be great to get a 0.19.0 onto PyPy PyPI since the Datastore v1beta2 API is being deprecated on 9/30

https://cloud.google.com/datastore/release-notes

This is a follow-up to our recent email to remind you that Google Cloud Datastore is turning down the v1beta1 and v1beta2 API on September 30, 2016.

The previous 0.18.1 release had v1beta2.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 15, 2016

@overset Thanks for the heads up. FWIW, we haven't supported v1beta2 for a very long time.

  • We upgraded from v1beta3 to v1 on August 16, 2016 (c52d363).
  • We upgraded from v1beta2 to v1beta3 on January 20, 2016 (64c28fd)

Check out the release history for relevant releases near those dates

@overset
Copy link

overset commented Sep 16, 2016

@dhermes My previous comment was flat-out wrong and thanks for confirming 0.18.1 having upgdaded to Datastore v1beta3 via 64c28fd. We haven't seen a turn-down notice for v1beta3 but it is marked as deprecated. (Thanks for the s/PyPy/PyPI/ on the previous comment as well)

@dhermes
Copy link
Contributor Author

dhermes commented Sep 16, 2016

Sure thing. Not sure when v1beta3 will be turned off.

@daspecster
Copy link
Contributor

@dhermes @tseaver @bjwatson, unless I'm missing something, I think we have all the items for this done?

We might want to have a PR to switch the naming back from #2264 or add it to this PR.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 19, 2016

This is the first release after the rename.

Closes googleapis#2264.
@dhermes
Copy link
Contributor Author

dhermes commented Sep 19, 2016

I also used the UI to look through merged PRs since August 9. I realized part way through that 0.18.1 wasn't a real release, it was a patch release due to broken PyPI deps, so I wanted to be extra careful.

Here is the release notes with stuff left out after. @daspecster Feel free to edit the vision parts inline as much as you like


Core

Resource Manager

Datastore

BigQuery

Vision

Pub / Sub

Logging

Bigtable

Monitoring

Natural Language


Not in notes.
Misc: #2339, #2335, #2311, #2065, #2067, #2085, #2088, #2090, #2096, #2097, #2135, #2141, #2151, #2212, #2227, #2241, #2257, #2272, #2288, #2292, #2304, #2056
Docs stuff (some dead code): #2052, #2103, #2110, #2039, #2115, #2129, #2122, #2155, #2147, #2171, #2175, #2178, #2188, #2191, #2174, #2199, #2153, #2219, #2247, #2267, #2269, #2282, #2281, #2302
Refactor private helpers: #2082, #2124, #2240
Misc. System test changes: #2313, #2050, #2087, #2202
Generated code: #2081
System test robustness: #2333, #2293, #2331, #2248, #2323, #2307, #2310, #2306, #2089, #2100, #2086, #2106, #2095, #2161, #2181, #2195, #2197, #2214, #2213, #2215, #2260, #2261, #2252, #2283, #2290, #2295

@tseaver
Copy link
Contributor

tseaver commented Sep 19, 2016

I've tweaked the entries all into imperative mode.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 19, 2016

Thanks @tseaver

@daspecster
Copy link
Contributor

daspecster commented Sep 19, 2016

I updated vision to be more verbose so it's easier to reference later if needed.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 19, 2016

Content moved to #2336.

@dhermes
Copy link
Contributor Author

dhermes commented Sep 19, 2016

@tseaver @daspecster Are we good to merge here? (Don't know why Travis is being fast on "push" builds to master but not "pr" builds.)

@daspecster
Copy link
Contributor

Green!

@tseaver
Copy link
Contributor

tseaver commented Sep 19, 2016

LGTM

@dhermes dhermes merged commit 4d66524 into googleapis:master Sep 19, 2016
@dhermes dhermes deleted the cut-0.19.0 branch September 19, 2016 18:40
@dhermes
Copy link
Contributor Author

dhermes commented Sep 19, 2016

Pushed the tag and added the notes: https://github.com/GoogleCloudPlatform/google-cloud-python/releases/tag/0.19.0 (may need #2347 update)

Push to PyPI should come from: https://travis-ci.org/GoogleCloudPlatform/google-cloud-python/builds/161121136

@tseaver
Copy link
Contributor

tseaver commented Sep 19, 2016

I updated the release notes to include the changes from #2347.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants