Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing pubsub and logging as namespace packages. #2334

Merged
merged 1 commit into from
Sep 16, 2016

Conversation

dhermes
Copy link
Contributor

@dhermes dhermes commented Sep 16, 2016

Fixes #2258.

See 73d2986 for the initial commit that removed the original contents of __init__.py (from #2223).

/cc @bjwatson

@dhermes dhermes added packaging api: pubsub Issues related to the Pub/Sub API. api: logging Issues related to the Cloud Logging API. labels Sep 16, 2016
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 16, 2016
@tseaver
Copy link
Contributor

tseaver commented Sep 16, 2016

LGTM

@dhermes
Copy link
Contributor Author

dhermes commented Sep 16, 2016

Dang Travis is fast! I still need to follow up with the fix for the pubsub and logging system tests. Working on it now.

@dhermes dhermes merged commit e5e7ab8 into googleapis:master Sep 16, 2016
@dhermes dhermes deleted the fix-2258 branch September 16, 2016 17:57
@dhermes dhermes mentioned this pull request Sep 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the Cloud Logging API. api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement. packaging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants