Vision text detection #2299
Merged
Vision text detection #2299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daspecster
added
do not merge
googlebot
added
the
cla: yes
daspecster
force-pushed
the
vision-text-detection
branch
2 times, most recently
from
deeb833
to
8b2e716
Compare
| @@ -210,10 +210,12 @@ Detecting text with ORC from an image. | |||
| >>> client = vision.Client() | |||
| >>> image = client.image('./image.jpg') | |||
| >>> text = image.detect_text() | |||
| >>> text.locale | |||
| >>> text[0].locale | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM: you can address my comments or leave them be, if you think best. |
daspecster
force-pushed
the
vision-text-detection
branch
from
8b2e716
to
b227338
Compare
|
Ok, I updated the code based on your comments. I'll let travis run and then I'll make the next two PRs. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #2237.
Adds text detection.
This is the last of the Entity based detections.
Safe Search and Image properties are left.